From: Charles Perry <charles.perry@savoirfairelinux.com>
To: mdf@kernel.org
Cc: avandiver@markem-imaje.com, bcody@markem-imaje.com,
Charles Perry <charles.perry@savoirfairelinux.com>,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] fpga: xilinx-selectmap: add new driver
Date: Wed, 31 Jan 2024 18:05:30 -0500 [thread overview]
Message-ID: <20240131230542.3993409-1-charles.perry@savoirfairelinux.com> (raw)
In-Reply-To: <20240129225602.3832449-1-charles.perry@savoirfairelinux.com>
Hello,
This patchset adds a new driver for the 7 series FPGA's SelectMAP
interface.
The SelectMAP interface shares a common GPIO protocol with the SPI
interface which is already in the kernel (drivers/fpga/xilinx-spi.c).
The approach proposed in this patchset is to refactor xilinx-spi.c into
xilinx-core.c which would handle the common GPIO protocol. This is then
used to build two drivers, the already existing xilinx-spi.c driver and
a newly added xilinx-selectmap.c driver.
The SelectMAP driver proposed only supports 8 bit mode. This is because
the 16 and 32 bits mode have limitations with regards to compressed
bitstream support as well as introducing endianness considerations.
I'm testing xilinx-selectmap.c on a custom i.MX6 board connected to an
Artix 7 FPGA. Flashing a 913K bitstream takes 0.44 seconds.
v2: From Krzysztof Kozlowski review's:
* Use more conventional names for gpio DT bindings
* fix example in DT bindings
* add mc-peripheral-props.yaml to DT bindings
* fix various formatting mistakes
* Remove all occurences of the "slave" word.
Charles Perry (3):
fpga: xilinx-spi: extract a common driver core
dt-bindings: fpga: xlnx,fpga-slave-selectmap: add DT schema
fpga: xilinx-selectmap: add new driver
.../bindings/fpga/xlnx,fpga-selectmap.yaml | 83 +++++++
drivers/fpga/Kconfig | 12 +
drivers/fpga/Makefile | 2 +
drivers/fpga/xilinx-core.c | 215 ++++++++++++++++++
drivers/fpga/xilinx-core.h | 28 +++
drivers/fpga/xilinx-selectmap.c | 106 +++++++++
drivers/fpga/xilinx-spi.c | 205 ++---------------
7 files changed, 462 insertions(+), 189 deletions(-)
create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,fpga-selectmap.yaml
create mode 100644 drivers/fpga/xilinx-core.c
create mode 100644 drivers/fpga/xilinx-core.h
create mode 100644 drivers/fpga/xilinx-selectmap.c
--
2.43.0
next prev parent reply other threads:[~2024-01-31 23:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 22:56 [PATCH 1/3] fpga: xilinx-spi: extract a common driver core Charles Perry
2024-01-29 22:56 ` [PATCH 2/3] dt-bindings: fpga: xlnx,fpga-slave-selectmap: add DT schema Charles Perry
2024-01-30 0:21 ` Rob Herring
2024-01-30 7:52 ` Krzysztof Kozlowski
2024-01-30 7:53 ` Krzysztof Kozlowski
2024-01-30 15:45 ` Charles Perry
2024-01-30 16:05 ` Krzysztof Kozlowski
2024-01-30 17:05 ` Charles Perry
2024-01-30 17:58 ` Krzysztof Kozlowski
2024-01-30 23:32 ` Charles Perry
2024-01-30 16:09 ` Krzysztof Kozlowski
2024-01-31 11:03 ` Kris Chaplin
2024-02-04 8:30 ` Xu Yilun
2024-02-13 21:54 ` Charles Perry
2024-01-29 22:56 ` [PATCH 3/3] fpga: xilinx-selectmap: add new driver Charles Perry
2024-01-30 7:56 ` Krzysztof Kozlowski
2024-01-31 23:05 ` Charles Perry [this message]
2024-01-31 23:05 ` [PATCH 1/3] fpga: xilinx-spi: extract a common driver core Charles Perry
2024-02-04 8:22 ` Xu Yilun
2024-02-06 15:39 ` Charles Perry
2024-01-31 23:05 ` [PATCH 2/3] dt-bindings: fpga: xlnx,fpga-slave-selectmap: add DT schema Charles Perry
2024-02-01 8:07 ` Krzysztof Kozlowski
2024-02-01 18:24 ` Charles Perry
2024-02-02 10:49 ` Krzysztof Kozlowski
2024-02-02 19:52 ` Charles Perry
2024-01-31 23:05 ` [PATCH 3/3] fpga: xilinx-selectmap: add new driver Charles Perry
2024-02-04 8:10 ` Xu Yilun
2024-02-06 15:48 ` Charles Perry
2024-02-02 20:16 ` [PATCH 0/3] " Rob Herring
2024-02-02 20:53 ` Charles Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131230542.3993409-1-charles.perry@savoirfairelinux.com \
--to=charles.perry@savoirfairelinux.com \
--cc=avandiver@markem-imaje.com \
--cc=bcody@markem-imaje.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).