[PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}

[PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}

[Peter Colberg]

The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
dfl: afu: add afu sub feature support") and to struct dfl_fme in commit
29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
support"). It is set in function {afu,fme}_dev_init() but never used.

Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
---
v2:
- Remove unused member pdata from struct dfl_fme, too.
---
 drivers/fpga/dfl-afu-main.c | 2 --
 drivers/fpga/dfl-afu.h      | 3 ---
 drivers/fpga/dfl-fme-main.c | 2 --
 drivers/fpga/dfl-fme.h      | 2 --
 4 files changed, 9 deletions(-)

diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c
index c0a75ca360d6..6b97c073849e 100644
--- a/drivers/fpga/dfl-afu-main.c
+++ b/drivers/fpga/dfl-afu-main.c
@@ -858,8 +858,6 @@ static int afu_dev_init(struct platform_device *pdev)
 	if (!afu)
 		return -ENOMEM;
 
-	afu->pdata = pdata;
-
 	mutex_lock(&pdata->lock);
 	dfl_fpga_pdata_set_private(pdata, afu);
 	afu_mmio_region_init(pdata);
diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h
index 674e9772f0ea..7bef3e300aa2 100644
--- a/drivers/fpga/dfl-afu.h
+++ b/drivers/fpga/dfl-afu.h
@@ -67,7 +67,6 @@ struct dfl_afu_dma_region {
  * @regions: the mmio region linked list of this afu feature device.
  * @dma_regions: root of dma regions rb tree.
  * @num_umsgs: num of umsgs.
- * @pdata: afu platform device's pdata.
  */
 struct dfl_afu {
 	u64 region_cur_offset;
@@ -75,8 +74,6 @@ struct dfl_afu {
 	u8 num_umsgs;
 	struct list_head regions;
 	struct rb_root dma_regions;
-
-	struct dfl_feature_platform_data *pdata;
 };
 
 /* hold pdata->lock when call __afu_port_enable/disable */
diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
index a2b5da0093da..864924f68f5e 100644
--- a/drivers/fpga/dfl-fme-main.c
+++ b/drivers/fpga/dfl-fme-main.c
@@ -679,8 +679,6 @@ static int fme_dev_init(struct platform_device *pdev)
 	if (!fme)
 		return -ENOMEM;
 
-	fme->pdata = pdata;
-
 	mutex_lock(&pdata->lock);
 	dfl_fpga_pdata_set_private(pdata, fme);
 	mutex_unlock(&pdata->lock);
diff --git a/drivers/fpga/dfl-fme.h b/drivers/fpga/dfl-fme.h
index 4195dd68193e..a566dbc2b485 100644
--- a/drivers/fpga/dfl-fme.h
+++ b/drivers/fpga/dfl-fme.h
@@ -24,13 +24,11 @@
  * @mgr: FME's FPGA manager platform device.
  * @region_list: linked list of FME's FPGA regions.
  * @bridge_list: linked list of FME's FPGA bridges.
- * @pdata: fme platform device's pdata.
  */
 struct dfl_fme {
 	struct platform_device *mgr;
 	struct list_head region_list;
 	struct list_head bridge_list;
-	struct dfl_feature_platform_data *pdata;
 };
 
 extern const struct dfl_feature_ops fme_pr_mgmt_ops;
-- 
2.44.0

Re: [PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}

[Xu Yilun]

On Mon, Apr 01, 2024 at 02:49:15PM -0400, Peter Colberg wrote:
> The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
> dfl: afu: add afu sub feature support") and to struct dfl_fme in commit
> 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
> support"). It is set in function {afu,fme}_dev_init() but never used.
> 
> Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next.

Re: [PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}

[Xu Yilun]

On Sat, Apr 13, 2024 at 11:10:22AM +0800, Xu Yilun wrote:
> On Mon, Apr 01, 2024 at 02:49:15PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
> > dfl: afu: add afu sub feature support") and to struct dfl_fme in commit

Sorry, I didn't apply. Please don't wrap the git commit description. Put
them in a new line but no wrap, if you have to reference git commit in
changelog.

> > 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
> > support").

This sentence is actually not useful, I suggest you just remove it and
add a Fix: tag below. That makes reviewers quickly find what the
problem. Also avoid the git commit references fragments the changelog
too much.

Thanks,
Yilun

> > It is set in function {afu,fme}_dev_init() but never used.
> > 
> > Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> 
> Acked-by: Xu Yilun <yilun.xu@intel.com>
> 
> Applied to for-next.
>