linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-arm-kernel@lists.infradead.org, linux-fpga@vger.kernel.org,
	Michal Simek <michal.simek@amd.com>,
	Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>
Subject: [PATCH v2 0/2] fpga: use 'time_left' instead of 'timeout' with wait_*() functions
Date: Thu, 20 Jun 2024 13:50:20 +0200	[thread overview]
Message-ID: <20240620115022.24409-1-wsa+renesas@sang-engineering.com> (raw)

There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_*() functions causing patterns like:

        timeout = wait_for_completion_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
obvious and self explaining.

This is part of a tree-wide series. The rest of the patches can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left

Because these patches are generated, I audit them before sending. This is why I
will send series step by step. Build bot is happy with these patches, though.
No functional changes intended.

Changes since v1 are stated per patch. Summary: I addressed review
comments and added acks.


Wolfram Sang (2):
  fpga: socfpga: use 'time_left' variable with wait_for_completion*()
  fpga: zynq-fpga: use 'time_left' variable with
    wait_for_completion_timeout()

 drivers/fpga/socfpga.c   | 7 ++++---
 drivers/fpga/zynq-fpga.c | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-06-20 11:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 11:50 Wolfram Sang [this message]
2024-06-20 11:50 ` [PATCH v2 1/2] fpga: socfpga: use 'time_left' variable with wait_for_completion*() Wolfram Sang
2024-06-22 14:51   ` Xu Yilun
2024-06-20 11:50 ` [PATCH v2 2/2] fpga: zynq-fpga: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-06-22 14:54   ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620115022.24409-1-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=hao.wu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).