From: kernel test robot <lkp@intel.com>
To: "Nuno Sá via B4 Relay" <devnull+nuno.sa.analog.com@kernel.org>,
linux-clk@vger.kernel.org, linux-fpga@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>
Subject: Re: [PATCH v2 6/6] clk: clk-axi-clkgen: fix coding style issues
Date: Fri, 14 Mar 2025 17:23:04 +0800 [thread overview]
Message-ID: <202503141741.UAwRQuuG-lkp@intel.com> (raw)
In-Reply-To: <20250313-dev-axi-clkgen-limits-v2-6-173ae2ad6311@analog.com>
Hi Nuno,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 82f69876ef45ad66c0b114b786c7c6ac0f6a4580]
url: https://github.com/intel-lab-lkp/linux/commits/Nuno-S-via-B4-Relay/clk-clk-axi-clkgen-fix-fpfd_max-frequency-for-zynq/20250313-231624
base: 82f69876ef45ad66c0b114b786c7c6ac0f6a4580
patch link: https://lore.kernel.org/r/20250313-dev-axi-clkgen-limits-v2-6-173ae2ad6311%40analog.com
patch subject: [PATCH v2 6/6] clk: clk-axi-clkgen: fix coding style issues
config: riscv-randconfig-002-20250314 (https://download.01.org/0day-ci/archive/20250314/202503141741.UAwRQuuG-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250314/202503141741.UAwRQuuG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503141741.UAwRQuuG-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/clk/clk-axi-clkgen.c: In function 'axi_clkgen_calc_clk_params':
>> drivers/clk/clk-axi-clkgen.c:229:35: warning: suggest parentheses around comparison in operand of '^' [-Wparentheses]
229 | if ((params->edge == 0 ^ frac_divider == 1) ||
| ~~~~~~~~~~~~~^~~~
vim +229 drivers/clk/clk-axi-clkgen.c
198
199 static void axi_clkgen_calc_clk_params(unsigned int divider,
200 unsigned int frac_divider,
201 struct axi_clkgen_div_params *params)
202 {
203 memset(params, 0x0, sizeof(*params));
204
205 if (divider == 1) {
206 params->nocount = 1;
207 return;
208 }
209
210 if (frac_divider == 0) {
211 params->high = divider / 2;
212 params->edge = divider % 2;
213 params->low = divider - params->high;
214 } else {
215 params->frac_en = 1;
216 params->frac = frac_divider;
217
218 params->high = divider / 2;
219 params->edge = divider % 2;
220 params->low = params->high;
221
222 if (params->edge == 0) {
223 params->high--;
224 params->frac_wf_r = 1;
225 }
226
227 if (params->edge == 0 || frac_divider == 1)
228 params->low--;
> 229 if ((params->edge == 0 ^ frac_divider == 1) ||
230 (divider == 2 && frac_divider == 1))
231 params->frac_wf_f = 1;
232
233 params->frac_phase = params->edge * 4 + frac_divider / 2;
234 }
235 }
236
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-03-14 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 15:14 [PATCH v2 0/6] clk: clk-axi-clkgen: improvements and some fixes Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 1/6] clk: clk-axi-clkgen: fix fpfd_max frequency for zynq Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 2/6] clk: clk-axi-clkgen: make sure to include mod_devicetable.h Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 3/6] include: fpga: adi-axi-common: add new helper macros Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 4/6] clk: clk-axi-clkgen: detect axi_clkgen_limits at runtime Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 5/6] clk: clk-axi-clkgen move to min/max() Nuno Sá via B4 Relay
2025-03-13 15:14 ` [PATCH v2 6/6] clk: clk-axi-clkgen: fix coding style issues Nuno Sá via B4 Relay
2025-03-14 9:23 ` kernel test robot [this message]
2025-03-17 5:26 ` Dan Carpenter
2025-03-17 16:47 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503141741.UAwRQuuG-lkp@intel.com \
--to=lkp@intel.com \
--cc=devnull+nuno.sa.analog.com@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=mturquette@baylibre.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sboyd@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).