Re: [PATCH v3 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3791 bytes --]

On Mon, Nov 17, 2025 at 03:02:11AM +0000, Romli, Khairul Anuar wrote:
> On 15/11/2025 1:59 am, Conor Dooley wrote:
> > On Fri, Nov 14, 2025 at 02:27:41PM +0800, Khairul Anuar Romli wrote:
> >> Agilex5 introduces changes in how reserved memory is mapped and accessed
> >> compared to previous SoC generations. Agilex5 compatible allows stratix10-
> >> FPGA manager driver to handle these changes.
> >>
> >> Fallback is added for driver probe and init that rely on matching of table
> >> and DT node.
> >>
> >> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> >> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> >> ---
> >> Changes in v3:
> >> 	- Add description for Agilex5 Device
> >> 	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
> >> 	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
> >> 	  (fallback)
> >> Changes in v2:
> >> 	- No changes in this patch
> >> ---
> >>   .../fpga/intel,stratix10-soc-fpga-mgr.yaml         | 14 +++++++++++---
> >>   1 file changed, 11 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> >> index 6e536d6b28a9..8eb414163d08 100644
> >> --- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> >> +++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
> >> @@ -20,9 +20,17 @@ description:
> >>   
> >>   properties:
> >>     compatible:
> >> -    enum:
> >> -      - intel,stratix10-soc-fpga-mgr
> >> -      - intel,agilex-soc-fpga-mgr
> >> +    oneOf:
> >> +      - items:
> >> +          - enum:
> > 
> > This construct is redundant, "items: - enum" is the same as just having
> > "enum".
> > pw-bot: changes-requested
> > 
> I've tried to look for some of the already merged bindings i.e 
> arm/qcom.yaml (although all the properties has enum - constant 
> combination), it is using items with enum. I tried to keep the enum without
> items but I keep getting error while validating the changes.

I literally told you what to change, so I don't know why you didn't just
do that. Replacing "items: - enum" with "enum" is what you need to do.
You didn't even include the error you got, so I cannot help you with
that at all, nor even if you did what I told you to do.

> Another option that I've validated is using the following changes.
> 
> -    enum:
> -      - intel,stratix10-soc-fpga-mgr
> -      - intel,agilex-soc-fpga-mgr
> +    oneOf:
> +      - description: Intel Stratix10 Devices
> +        items:
> +          - const: intel,stratix10-soc-fpga-mgr

These just have the same problem as your original patch.
"items: - const" is just the same as "const".
Since item "items" properties do not do anything other than bloat the
schema.

> +      - description: Intel Agilex Devices
> +        items:
> +          - const: intel,agilex-soc-fpga-mgr
> +      - description: Intel Agilex5 Devices
> +        items:
> +          - const: intel,agilex5-soc-fpga-mgr
> +          - const: intel,agilex-soc-fpga-mgr
> 
> The drawback of this is we will need to implement enum instead of 
> constant for first element if we need to add new devices under "Intel 
> Agilex5 Devices" in the future.
> 
> Thanks.
> 
> Best Regards,
> Khairul
> 
> >> +              - intel,stratix10-soc-fpga-mgr
> >> +              - intel,agilex-soc-fpga-mgr
> >> +
> >> +      - description: Agilex5 Device
> >> +        items:
> >> +          - enum:
> >> +              - intel,agilex5-soc-fpga-mgr
> >> +          - const: intel,agilex-soc-fpga-mgr
> >>   
> >>   required:
> >>     - compatible
> >> -- 
> >> 2.43.7
> >>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]