From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227722BF00A; Wed, 8 Apr 2026 15:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775663145; cv=none; b=eIrIPasxgS5/qwSHk/Nfs0fdXnjXgV9K+a91rZ54O/jcY2azKOhHX7CV9Ul01YnIkQERQMCmhSq2Vx8tZwashoTE6Z1uAdD9faXa056kcvtRcpcg2IPfecd6T+xcIBMdqNqNRL9ScECO+NGpGPDSg4x3ztHgKa4aICDeMMhhgxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775663145; c=relaxed/simple; bh=HzAJUow3pofQYIKNr/pPkhGBFLxA2vbEVNNrOk25Srg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XcCcQ240lI0ju2oWrQ6fkL2I7kHmGT6SDPPUm+6BaCqmFA1TT+5a9HPdc6X+x86ueqxe0++ZSWZwdg+INmb1DWl+H4ychvpXhm9EAbYPk+50+si/f/lj/ktT9tj1gMB3E7iJOj9wHFuAkiiQVisKeXbIVbIjXX56N0fKXVE834o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowADHWQ0geNZpdH31DA--.33830S2; Wed, 08 Apr 2026 23:45:36 +0800 (CST) From: Wentao Liang To: Moritz Fischer , Xu Yilun Cc: Tom Rix , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] fpga: region: fix use-after-free in child_regions_with_firmware() Date: Wed, 8 Apr 2026 15:45:34 +0000 Message-Id: <20260408154534.404327-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowADHWQ0geNZpdH31DA--.33830S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKw45tr1UJrW5CF13KFykZrb_yoWfCwbEkF 90qF93WF1DGFsxu39xJr13Z3sFy3WkWan3W3s7ta1aqws8Zr17Wr4Yvr1kA34UWa1UAr9x Xw1DtF9rC3sFyjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_ Jw1lc2xSY4AK67AK6ryrMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7VUjwSdDUUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRALA2nWbq8RlQAAsr Move of_node_put(child_region) after the error print to avoid accessing freed memory when pr_err() references child_region. Fixes: ef3acdd82075 ("fpga: region: move device tree support to of-fpga-region.c") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/fpga/of-fpga-region.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index caa091224dc5..9107a5b461d3 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -168,11 +168,10 @@ static int child_regions_with_firmware(struct device_node *overlay) fpga_region_of_match); } - of_node_put(child_region); - if (ret) pr_err("firmware-name not allowed in child FPGA region: %pOF", child_region); + of_node_put(child_region); return ret; } -- 2.34.1