Re: [PATCH] dt-bindings: fpga: altr,socfpga-fpga-mgr: convert to DT schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2941 bytes --]

On Tue, May 12, 2026 at 04:50:58PM +0000, Manish Baing wrote:
> Convert the Altera SoCFPGA FPGA Manager bindings from text
> format to YAML schema.
> 
> Signed-off-by: Manish Baing <manishbaing2789@gmail.com>
> ---
>  .../bindings/fpga/altera-socfpga-fpga-mgr.txt | 17 --------
>  .../bindings/fpga/altr,socfpga-fpga-mgr.yaml  | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/fpga/altera-socfpga-fpga-mgr.txt
>  create mode 100644 Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/altera-socfpga-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/altera-socfpga-fpga-mgr.txt
> deleted file mode 100644
> index d52f3340414d..000000000000
> --- a/Documentation/devicetree/bindings/fpga/altera-socfpga-fpga-mgr.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Altera SOCFPGA FPGA Manager
> -
> -Required properties:
> -- compatible : should contain "altr,socfpga-fpga-mgr"
> -- reg        : base address and size for memory mapped io.
> -               - The first index is for FPGA manager register access.
> -               - The second index is for writing FPGA configuration data.
> -- interrupts : interrupt for the FPGA Manager device.
> -
> -Example:
> -
> -	hps_0_fpgamgr: fpgamgr@ff706000 {
> -		compatible = "altr,socfpga-fpga-mgr";
> -		reg = <0xFF706000 0x1000
> -		       0xFFB90000 0x1000>;
> -		interrupts = <0 175 4>;
> -	};
> diff --git a/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml
> new file mode 100644
> index 000000000000..d09d552dde5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altr,socfpga-fpga-mgr.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/altr,socfpga-fpga-mgr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera SOCFPGA FPGA Manager
> +
> +maintainers:
> +  - Steffen Trumtrar <s.trumtrar@pengutronix.de>
> +  - Rob Herring <robh@kernel.org>

Why's Rob a maintainer here? Doubt he cares about this device.

Otherwise this looks okay.


> +
> +properties:
> +  compatible:
> +    const: altr,socfpga-fpga-mgr
> +
> +  reg:
> +    items:
> +      - description: FPGA manager register access
> +      - description: Writing FPGA configuration data
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    fpgamgr@ff706000 {
> +        compatible = "altr,socfpga-fpga-mgr";
> +        reg = <0xff706000 0x1000>,
> +              <0xffb90000 0x1000>;
> +        interrupts = <0 175 4>;
> +    };
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]