From: Tom Rix <trix@redhat.com>
To: Luca Ceresoli <luca@lucaceresoli.net>, linux-fpga@vger.kernel.org
Cc: Moritz Fischer <mdf@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH v3 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure
Date: Fri, 28 Aug 2020 13:17:57 -0700 [thread overview]
Message-ID: <20e0b1e3-938e-9020-a4b5-02e24692557d@redhat.com> (raw)
In-Reply-To: <20200828195808.27975-5-luca@lucaceresoli.net>
On 8/28/20 12:58 PM, Luca Ceresoli wrote:
> When the DONE pin does not go high after programming to confirm programming
> success, the INIT_B pin provides some info on the reason. Use it if
> available to provide a more explanatory error message.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
This patch set looks good to me.
Thanks
Tom
Reviewed-by: Tom Rix <trix@redhat.com>
prev parent reply other threads:[~2020-08-28 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 19:58 [PATCH v3 1/5] fpga manager: xilinx-spi: remove stray comment Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() Luca Ceresoli
2020-08-29 3:30 ` kernel test robot
2020-08-29 21:08 ` Luca Ceresoli
2020-08-28 19:58 ` [PATCH v3 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Luca Ceresoli
2020-08-28 20:17 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e0b1e3-938e-9020-a4b5-02e24692557d@redhat.com \
--to=trix@redhat.com \
--cc=agust@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).