From: John Hubbard <jhubbard@nvidia.com>
To: Xu Yilun <yilun.xu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Wu Hao <hao.wu@intel.com>,
Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()
Date: Tue, 19 May 2020 10:39:02 -0700 [thread overview]
Message-ID: <2e9e6c4e-296d-b0cd-88ce-1b300b9e2e0f@nvidia.com> (raw)
In-Reply-To: <20200519151037.GA20726@yilunxu-OptiPlex-7050>
On 2020-05-19 08:10, Xu Yilun wrote:
...
>> @@ -72,7 +63,7 @@ static int afu_dma_pin_pages(struct dfl_feature_platform_data *pdata,
>> return 0;
>>
>> put_pages:
>
> How about we also change the tag to "unpin_pages"?
>
> Others look good to me.
>
Sure, I'll send a v2 with that.
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2020-05-19 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 1:18 [PATCH] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages() John Hubbard
2020-05-19 15:10 ` Xu Yilun
2020-05-19 17:39 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9e6c4e-296d-b0cd-88ce-1b300b9e2e0f@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).