From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85E6C433E6 for ; Wed, 27 Jan 2021 12:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C83F20771 for ; Wed, 27 Jan 2021 12:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231962AbhA0Msx (ORCPT ); Wed, 27 Jan 2021 07:48:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:1762 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbhA0Mqn (ORCPT ); Wed, 27 Jan 2021 07:46:43 -0500 IronPort-SDR: UdQZReNievoMq2Ay0O8tvqMOr8ALMf4c1Q3iu2C4KxhSOyzSoFcC131KO6jo5BcrSRtj5l8fK4 GuHwqui3wJFA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="180140525" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="180140525" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:44:56 -0800 IronPort-SDR: UY66y7hlTgMWE7SAKaZ+FYqbWxrF5r0DuNU7oPyCc5tNnyCW+SQ6Jpfo8f6GMEIKa8I7+o9nXb nqItxCBoilBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="357054026" Received: from marshy.an.intel.com (HELO [10.122.105.143]) ([10.122.105.143]) by orsmga006.jf.intel.com with ESMTP; 27 Jan 2021 04:44:55 -0800 Subject: Re: [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag To: Greg KH Cc: mdf@kernel.org, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1611608188-25621-1-git-send-email-richard.gong@linux.intel.com> <1611608188-25621-2-git-send-email-richard.gong@linux.intel.com> From: Richard Gong Message-ID: <2f9d082b-9970-8f41-0351-324f1bad6cbf@linux.intel.com> Date: Wed, 27 Jan 2021 07:05:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Hi Greg, Thanks for review! On 1/27/21 6:04 AM, Greg KH wrote: > On Mon, Jan 25, 2021 at 02:56:23PM -0600, richard.gong@linux.intel.com wrote: >> From: Richard Gong >> >> Add COMMAND_AUTHENTICATE_BITSTREAM command flag for new added bitstream >> authentication feature. Authenticating a bitstream is to make sure a signed >> bitstream has the valid signatures. >> >> Except for the actual configuration of the device, the bitstream >> authentication works the same way as FPGA configuration does. If the >> authentication passes, the signed bitstream will be programmed into QSPI >> flash memory and will be expected to boot without issues. >> >> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which >> aligns with the firmware settings. >> >> Signed-off-by: Richard Gong >> --- >> v3: no change >> v2: new added >> --- >> include/linux/firmware/intel/stratix10-svc-client.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h >> index ebc2956..7ada1f2 100644 >> --- a/include/linux/firmware/intel/stratix10-svc-client.h >> +++ b/include/linux/firmware/intel/stratix10-svc-client.h >> @@ -51,12 +51,17 @@ >> #define SVC_STATUS_NO_SUPPORT 6 >> >> /* >> - * Flag bit for COMMAND_RECONFIG >> + * Flag for COMMAND_RECONFIG, in bit number >> * >> * COMMAND_RECONFIG_FLAG_PARTIAL: >> - * Set to FPGA configuration type (full or partial). >> + * Set for partial FPGA configuration. >> + * >> + * COMMAND_AUTHENTICATE_BITSTREAM: >> + * Set for bitstream authentication, which makes sure a signed bitstream >> + * has valid signatures before committing it to QSPI flash memory. >> */ >> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 >> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 > > So is this a bugfix, changing this value to the correct one? Yes, it is a bug fix. > > If so, shouldn't this be a stand-alone patch and get backported to > stable kernel releases? Sure, I will make change and submit again as a standalone patch. > > If not, then no one uses this flag today? > > thanks, > > greg k-h > Regards, Richard