Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/11/2025 05:43, Khairul Anuar Romli wrote:
> The Intel Agilex 5 SoC contains a programmable FPGA region that requires
> proper device tree description to enable FPGA manager support in the Linux
> kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot
> detect or manage the FPGA hardware correctly.
> 
> This patch adds a 'fpga-region' node with compatible = "fpga-region", along
> with appropriate #address-cells and #size-cells properties, to describe the
> FPGA region layout.
> 
> Also defines specific compatible string for Agilex5 and add Agilex string
> as fallback for stratix10-soc driver initialization.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v2:
> 	- All fallback compatible string to ensure driver is still able to
> 	  initialize without new compatible string added in the driver.
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index bf7128adddde..06be0b8671c0 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -85,9 +85,21 @@ svc {
>  			method = "smc";
>  			memory-region = <&service_reserved>;
>  			iommus = <&smmu 10>;
> +
> +			fpga_mgr: fpga-mgr {
> +				compatible = "intel,agilex5-soc-fpga-mgr",
> +					     "intel,agilex-soc-fpga-mgr";


You did not bother to test this...

Best regards,
Krzysztof