From: Tom Rix <trix@redhat.com>
To: Russ Weight <russell.h.weight@intel.com>,
mdf@kernel.org, lee.jones@linaro.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com
Subject: Re: [PATCH v5 5/6] fpga: m10bmc-sec: add max10 secure update functions
Date: Wed, 18 Nov 2020 07:57:05 -0800 [thread overview]
Message-ID: <3fe70aff-b0ac-22dd-5f90-53924b20d8ef@redhat.com> (raw)
In-Reply-To: <4819688e-4967-360d-6ba7-36b93735b42d@intel.com>
On 11/17/20 4:10 PM, Russ Weight wrote:
>
> On 11/15/20 6:17 AM, Tom Rix wrote:
>> On 11/13/20 4:55 PM, Russ Weight wrote:
>>> Extend the MAX10 BMC Secure Update driver to include
>>>
>>> +
>>> + status = rsu_stat(doorbell);
>>> + if (status == RSU_STAT_WEAROUT) {
>>> + dev_warn(sec->dev, "Excessive flash update count detected\n");
>> If wear out is going to flood logs, move this to a warn once.
> There is no danger of flooding. The WEAROUT error will only be seen after 1000
> flash updates have occurred - an unlikely condition. It will also only occur
> once on an update, and only if they attempt to flash within 60 seconds of
> power-on or within 60 seconds of a previous flash.
>> Maybe make rsu_stat a function.
> Is there a reason to prefer a function in this case? Or should I change
> rsu_stat() to RSU_STAT() to make it more clear that it is a macro?
i was thinking a function could manage the warning messages.
If it will not flood, it is ok as-is.
Tom
next prev parent reply other threads:[~2020-11-18 15:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:55 [PATCH v5 0/6] Intel MAX10 BMC Secure Update Driver Russ Weight
2020-11-14 0:55 ` [PATCH v5 1/6] mfd: intel-m10-bmc: support for MAX10 BMC Secure Updates Russ Weight
2020-11-14 0:55 ` [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver Russ Weight
2020-11-15 13:44 ` Tom Rix
2020-11-17 23:38 ` Russ Weight
2020-11-18 15:47 ` Tom Rix
2020-11-14 0:55 ` [PATCH v5 3/6] fpga: m10bmc-sec: expose max10 flash update count Russ Weight
2020-11-15 20:03 ` Moritz Fischer
2020-11-17 23:45 ` Russ Weight
2020-11-14 0:55 ` [PATCH v5 4/6] fpga: m10bmc-sec: expose max10 canceled keys in sysfs Russ Weight
2020-11-14 0:55 ` [PATCH v5 5/6] fpga: m10bmc-sec: add max10 secure update functions Russ Weight
2020-11-15 14:17 ` Tom Rix
2020-11-18 0:10 ` Russ Weight
2020-11-18 15:57 ` Tom Rix [this message]
2020-11-14 0:55 ` [PATCH v5 6/6] fpga: m10bmc-sec: add max10 get_hw_errinfo callback func Russ Weight
2020-11-15 14:20 ` Tom Rix
2020-11-18 0:16 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe70aff-b0ac-22dd-5f90-53924b20d8ef@redhat.com \
--to=trix@redhat.com \
--cc=hao.wu@intel.com \
--cc=lee.jones@linaro.org \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).