From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9C2C433B4 for ; Tue, 13 Apr 2021 14:41:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9AC5613AB for ; Tue, 13 Apr 2021 14:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343989AbhDMOmB (ORCPT ); Tue, 13 Apr 2021 10:42:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25430 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344179AbhDMOmB (ORCPT ); Tue, 13 Apr 2021 10:42:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618324900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TViGrSHXxRTqM3saQJnRZcxR43Mym++wZTJJ2EWtIto=; b=WMWELS9DQh5aEI23JowwUCwWAwuB2cQd0dJHcLS2kW1pag4+QRt7HRe8UZfAvRBd71HjYO N4UwOxGHg5rK9YvqHzaPezgaPK0ZTlzmqxhOtv0isUWJyCxw0Q10yb+67MfZ9XxKQBana1 C3KglPFeBZfvbVe9QPiSVQSEKv4+q80= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-L0R05639MaqfJ4UFHJmkJA-1; Tue, 13 Apr 2021 10:41:38 -0400 X-MC-Unique: L0R05639MaqfJ4UFHJmkJA-1 Received: by mail-qk1-f200.google.com with SMTP id c9so4524433qkm.11 for ; Tue, 13 Apr 2021 07:41:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=TViGrSHXxRTqM3saQJnRZcxR43Mym++wZTJJ2EWtIto=; b=mda7qv0AaDq5ykYDorqWEva5IDCLQGeVfwEdWZu98QVT2wjaqHqEfcyVBMD8YHplEG 7nl3jHeiXQ7WmWgSQYgfzFg+mad8jIIstf6LRrJw2YGWk0270XxkzkgE4cl+q2ToUjjk ZjhgdR4z1KEjj5G/EkY4TAN/KsE8vbUtzvLhiezXgiT1Ih9erFws4yS0Pr2wq4UmsXoP Xpzw5b/+u1g3hvdvNgL9dn7p7UKQr02t5gSObnuhcg68AyhHOUdSQQcz5CAOv5ZSSLby 6b4sulYiwaKNvtAfGTENUkQmHskNAftK3wkJHD/c4u5PAOz5SUO6pqtBHvHEn6yZZUhk JOJg== X-Gm-Message-State: AOAM530cH0GaZkMk32XWsx1HDfB30/8tIEiOMd62KR3QKMfod23Q0RJt 26i2H0+OM70FkpCBcjb+P5a73elwqa6x9Ikl76nTUC7aBxsZOHMvExbhUjFqL3/JZfSpzMqPSir +LYQoFTA1LJ1gjwTczWYD/A== X-Received: by 2002:a37:ae86:: with SMTP id x128mr32631306qke.427.1618324898269; Tue, 13 Apr 2021 07:41:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV2RTDXFsn/MqdWIiA0uOrBI4PKyyvlH52vYsv5jFW+FN5kErFac+ntPs/2hsIVEymw4vR/Q== X-Received: by 2002:a37:ae86:: with SMTP id x128mr32631289qke.427.1618324898074; Tue, 13 Apr 2021 07:41:38 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id k17sm3577246qtp.26.2021.04.13.07.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 07:41:37 -0700 (PDT) Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove useless function To: Jiapeng Chong , mdf@kernel.org Cc: michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1618285894-111432-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Tom Rix Message-ID: <40a0449f-37c4-6b3a-5a34-d865db971f9f@redhat.com> Date: Tue, 13 Apr 2021 07:41:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1618285894-111432-1-git-send-email-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 4/12/21 8:51 PM, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/fpga/xilinx-pr-decoupler.c:32:19: warning: unused function > 'xlnx_pr_decouple_read' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/fpga/xilinx-pr-decoupler.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index 7d69af2..f407cb2 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -29,12 +29,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, > writel(val, d->io_base + offset); > } > > -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > - u32 offset) > -{ > - return readl(d->io_base + offset); > -} > - I am not in favor of removing this function. It should have been used in xlnx_pr_decoupler_enable_show() instead of the bare readl(). So use it in this function, and for consistency rename to xlnx_pr_decoupler_read() that is 'decouple' -> 'decoupler' Tom > static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) > { > int err;