From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A518B189F47 for ; Tue, 20 Aug 2024 08:13:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724141629; cv=none; b=LEoHAQtWuas15+cWY1neD4GUnCNupYkQROIq7+ChZZOssclEoBRTEtzsRDxkeI7mzCRlHz1Qd8BHJCkR3b2wronoF87HreD/on8Rt9MSN86WxoC8ia+7xtYnSi8SgpPR7EZ2I0rcK2V/971Rst40XLSwHUtrF3sDr0zeyFTyom4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724141629; c=relaxed/simple; bh=5x2Zwvil69v7j2QTmo/ru3l3YhUvaf/XafPWpjOjfD8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=l2eAgR5SxLD33q7F7pfbEgbK9I0tvzM0NkYmprQuvyJ9za9B09PNlkOsgwcGogEnKkQeeqwR2KNe6dOX6G4+scvg1NFgaryWJcHufY4q9w1iXKtsiiqhIIgEbJcwiQ4nZVa/hpo9cfe/V2BhIGF2/WKvUaCMVQ8+k5LcOWOUfb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V+ZmSPrW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V+ZmSPrW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724141626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5x2Zwvil69v7j2QTmo/ru3l3YhUvaf/XafPWpjOjfD8=; b=V+ZmSPrWuPW6iLzzX/1uzcNwn98hDSrf6VhFntnNxB76lX0aWT4ijx7J/jymC2ubpNZoSc S+b3c5MZ348SKGP2k32ka4MpVzVZtZng0TyzFIh+Ta/wL9DolYpmYLiPrNL/2iNRMVE0dJ RpN3S3RxZZugSzgnHCeCxk/5URbfDM4= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-LBBP7PACOxu2SrAIPqUvxQ-1; Tue, 20 Aug 2024 04:13:44 -0400 X-MC-Unique: LBBP7PACOxu2SrAIPqUvxQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2f3f157cd18so194111fa.0 for ; Tue, 20 Aug 2024 01:13:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724141623; x=1724746423; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5x2Zwvil69v7j2QTmo/ru3l3YhUvaf/XafPWpjOjfD8=; b=q0lWIdnYVvDM2XkLxSbNBCCqyN68Rzmcxdi96CwBr8u1cRGX4xWXtfLD0+6kKufyeR 7njNmDdQOGSWVY9JbKKZ8QKvyjWPTS5pEmmNssl65FmkGIRvGSiSkNwSKuyxfeFWzlA4 WHkj2xgTsLFRZYiZr9z4/c+8YAbiSnJzVOmSG9OWiZGt2Yy8wBHFpdUiFTfS3G/tTCIB FoMwEkDE6gFqNY6qjxAdzgeHrrz6BNe/dRHDNBMm5D5T7PZxXvrij1qG/kV5pjg8OOF7 R/hMOTkpSgOHo5I01NckJlWsLpvbhz51jxfXS8qQPYxVOZ0e246XEoE3V7F38f8jLXy/ poRw== X-Forwarded-Encrypted: i=1; AJvYcCXYztlrvpAfFyv8Q4Qdb4SAzO2ki7tUPkhT5DwZNAZa7jXSn8B3SuKrK1o85GhrBGw/oqJqF/5i6ito@vger.kernel.org X-Gm-Message-State: AOJu0Ywhlpa5Gj03t/ziSfsMY3FMOeWNjJyuZhfI1oua8nZo9/1uCEIw 34SrEG02e9FdeHtbE7RqXBJuF5PmjLRNQF7suw6Hlt8UK7U2YE1NjwGjtAXFjQ8SJW7iIgfx5F2 vnAJBc0MXIF6tGyBfsgGPtQGJ/vG4M7BqSWeJD69qr+Cutsz8GQQal8OcRmY= X-Received: by 2002:a05:6512:10c1:b0:530:e0fd:4a85 with SMTP id 2adb3069b0e04-5331c6d4a61mr5183708e87.4.1724141623043; Tue, 20 Aug 2024 01:13:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZQZIXMi/Gkd3uNyVjKj7Xpsxjs4S0/m1lMVeXOF/ppQ1u+jlQhYOCzCKjOM9+Rw34AQB54A== X-Received: by 2002:a05:6512:10c1:b0:530:e0fd:4a85 with SMTP id 2adb3069b0e04-5331c6d4a61mr5183700e87.4.1724141622413; Tue, 20 Aug 2024 01:13:42 -0700 (PDT) Received: from eisenberg.fritz.box ([2001:16b8:3dcc:1f00:bec1:681e:45eb:77e2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8383935616sm724162966b.123.2024.08.20.01.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 01:13:42 -0700 (PDT) Message-ID: <419e91cb2b698a450497dfc1fb86f2c46eb7d8fb.camel@redhat.com> Subject: Re: [PATCH 8/9] vdap: solidrun: Replace deprecated PCI functions From: Philipp Stanner To: Andy Shevchenko , Christophe JAILLET Cc: onathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?ISO-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Date: Tue, 20 Aug 2024 10:13:40 +0200 In-Reply-To: References: <20240819165148.58201-2-pstanner@redhat.com> <20240819165148.58201-10-pstanner@redhat.com> <74e9109a-ac59-49e2-9b1d-d825c9c9f891@wanadoo.fr> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-08-19 at 21:34 +0300, Andy Shevchenko wrote: > On Mon, Aug 19, 2024 at 08:19:28PM +0200, Christophe JAILLET wrote: > > Le 19/08/2024 =C3=A0 18:51, Philipp Stanner a =C3=A9crit=C2=A0: >=20 >=20 > ... >=20 > > Unrelated to the patch, but is is safe to have 'name' be on the > > stack? > >=20 > > pcim_iomap_region() > > --> __pcim_request_region() > > --> __pcim_request_region_range() > > --> request_region() or __request_mem_region() > > --> __request_region() > > --> __request_region_locked() > > --> res->name =3D name; > >=20 > > So an address on the stack ends in the 'name' field of a "struct > > resource". > >=20 > > According to a few grep, it looks really unusual. > >=20 > > I don't know if it is used, but it looks strange to me. >=20 > It might be used when printing /proc/iomem, but I don't remember by > heart. >=20 > > If it is an issue, it was apparently already there before this > > patch. >=20 > This series seems to reveal a lot of issues with the probe/remove in > many > drivers. I think it's better to make fixes of them before this series > for > the sake of easier backporting. Just so we're in sync: I think the only real bug here so far is the one found by Christophe. The usages of pci_disable_device(), pcim_iounmap_regions() and the like in remove() and error unwind paths are not elegant and make devres kind of useless =E2=80=93 but they are not bugs. So I wouldn't backport them. P. >=20 > If here is a problem, the devm_kasprintf() should be used. >=20