From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, iansdannapel@gmail.com,
"Moritz Fischer" <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko.stuebner@cherry.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Andre Przywara" <andre.przywara@arm.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Ian Dannapel <iansdannapel@gmail.com>
Subject: Re: [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver
Date: Tue, 2 Jul 2024 23:27:12 +0200 [thread overview]
Message-ID: <6286e61c-6822-40d4-a43e-617a4ce257ca@suswa.mountain> (raw)
In-Reply-To: <20240628152348.61133-2-iansdannapel@gmail.com>
Hi,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/iansdannapel-gmail-com/fpga-Add-Efinix-Trion-Titanium-serial-SPI-programming-driver/20240630-044745
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240628152348.61133-2-iansdannapel%40gmail.com
patch subject: [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver
config: powerpc-randconfig-r081-20240701 (https://download.01.org/0day-ci/archive/20240703/202407030525.VHF3He6K-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202407030525.VHF3He6K-lkp@intel.com/
smatch warnings:
drivers/fpga/efinix-trion-spi-passive.c:174 efinix_spi_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +174 drivers/fpga/efinix-trion-spi-passive.c
4c272ecc14b70f Ian Dannapel 2024-06-28 152 static int efinix_spi_probe(struct spi_device *spi)
4c272ecc14b70f Ian Dannapel 2024-06-28 153 {
4c272ecc14b70f Ian Dannapel 2024-06-28 154 struct efinix_spi_conf *conf;
4c272ecc14b70f Ian Dannapel 2024-06-28 155 struct fpga_manager *mgr;
4c272ecc14b70f Ian Dannapel 2024-06-28 156
4c272ecc14b70f Ian Dannapel 2024-06-28 157 conf = devm_kzalloc(&spi->dev, sizeof(*conf), GFP_KERNEL);
4c272ecc14b70f Ian Dannapel 2024-06-28 158 if (!conf)
4c272ecc14b70f Ian Dannapel 2024-06-28 159 return -ENOMEM;
4c272ecc14b70f Ian Dannapel 2024-06-28 160
4c272ecc14b70f Ian Dannapel 2024-06-28 161 conf->spi = spi;
4c272ecc14b70f Ian Dannapel 2024-06-28 162
4c272ecc14b70f Ian Dannapel 2024-06-28 163 conf->creset = devm_gpiod_get(&spi->dev, "creset", GPIOD_OUT_HIGH);
4c272ecc14b70f Ian Dannapel 2024-06-28 164 if (IS_ERR(conf->creset))
4c272ecc14b70f Ian Dannapel 2024-06-28 165 return dev_err_probe(&spi->dev, PTR_ERR(conf->creset),
4c272ecc14b70f Ian Dannapel 2024-06-28 166 "Failed to get RESET gpio\n");
4c272ecc14b70f Ian Dannapel 2024-06-28 167
4c272ecc14b70f Ian Dannapel 2024-06-28 168 conf->cs = devm_gpiod_get(&spi->dev, "cs", GPIOD_OUT_HIGH);
4c272ecc14b70f Ian Dannapel 2024-06-28 169 if (IS_ERR(conf->cs))
4c272ecc14b70f Ian Dannapel 2024-06-28 170 return dev_err_probe(&spi->dev, PTR_ERR(conf->cs),
4c272ecc14b70f Ian Dannapel 2024-06-28 171 "Failed to get CHIP_SELECT gpio\n");
4c272ecc14b70f Ian Dannapel 2024-06-28 172
4c272ecc14b70f Ian Dannapel 2024-06-28 173 if (!(spi->mode & SPI_CPHA) || !(spi->mode & SPI_CPOL))
4c272ecc14b70f Ian Dannapel 2024-06-28 @174 return dev_err_probe(&spi->dev, PTR_ERR(conf->cs),
s/conf->cs/-EINVAL/
4c272ecc14b70f Ian Dannapel 2024-06-28 175 "Unsupported SPI mode, set CPHA and CPOL\n");
4c272ecc14b70f Ian Dannapel 2024-06-28 176
4c272ecc14b70f Ian Dannapel 2024-06-28 177 conf->cdone = devm_gpiod_get_optional(&spi->dev, "cdone", GPIOD_IN);
4c272ecc14b70f Ian Dannapel 2024-06-28 178 if (IS_ERR(conf->cdone))
4c272ecc14b70f Ian Dannapel 2024-06-28 179 return dev_err_probe(&spi->dev, PTR_ERR(conf->cdone),
4c272ecc14b70f Ian Dannapel 2024-06-28 180 "Failed to get CDONE gpio\n");
4c272ecc14b70f Ian Dannapel 2024-06-28 181
4c272ecc14b70f Ian Dannapel 2024-06-28 182 mgr = devm_fpga_mgr_register(&spi->dev,
4c272ecc14b70f Ian Dannapel 2024-06-28 183 "Efinix SPI Passive Programming FPGA Manager",
4c272ecc14b70f Ian Dannapel 2024-06-28 184 &efinix_spi_ops, conf);
4c272ecc14b70f Ian Dannapel 2024-06-28 185
4c272ecc14b70f Ian Dannapel 2024-06-28 186 return PTR_ERR_OR_ZERO(mgr);
4c272ecc14b70f Ian Dannapel 2024-06-28 187 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-07-02 21:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:42 [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-06-20 18:05 ` Marco Pagani
2024-06-28 15:23 ` [PATCH v2 0/3] Summary of changes iansdannapel
2024-06-28 15:23 ` [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-07-02 21:27 ` Dan Carpenter [this message]
2024-07-12 6:53 ` Xu Yilun
2024-07-25 13:44 ` Ian Dannapel
2024-07-27 15:58 ` Xu Yilun
2024-07-28 11:44 ` Ian Dannapel
2024-07-29 14:50 ` Xu Yilun
2024-08-09 10:38 ` Ian Dannapel
2024-06-28 15:23 ` [PATCH v2 2/3] dt-bindings: fpga: Add Efinix serial SPI programming bindings iansdannapel
2024-06-28 16:07 ` Conor Dooley
2024-06-28 15:23 ` [PATCH v2 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-06-28 16:00 ` Conor Dooley
2024-07-02 8:57 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6286e61c-6822-40d4-a43e-617a4ce257ca@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=heiko.stuebner@cherry.de \
--cc=iansdannapel@gmail.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=macromorgan@hotmail.com \
--cc=mdf@kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=neil.armstrong@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).