From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02260148FF0 for ; Tue, 2 Jul 2024 21:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719955637; cv=none; b=Pz0SuJMWSP9pJNmhbCiczh1yT+Qy4pcs5xEynjK6ebcUEmZq/24vcskhYBF36c/RfoRqBiHOsltmGyPx5eXr4k+DNiUkeW7/8eql2pr1kf4xMOmDYRosFEJZ+IODZOWpXVnOR93KvCMbK7QulrxHwElDiut+hWOHNh7YO9Km8PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719955637; c=relaxed/simple; bh=O+o3Ib11ciLZU7Bvqliq2+mbTCErwHIwUfXdIcVPsOM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=GLvXlfwqJqIJT6OaNScp74XwlFVRLe++2PWSsgpJwVwO5fR33P7ynq8CEJ0ILnrqx+ObdgdGhM6OGg8TVSyLPw0Meo7G5m3qo4iTUoeqz5ltOMlZKubE+5HLRKnIhGrlMbXmoqMOED2ecREoH73oy+e9Dy3vPN3Jn6CCjPBtrLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A90aQDSm; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A90aQDSm" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-25982aa59efso2161338fac.3 for ; Tue, 02 Jul 2024 14:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719955635; x=1720560435; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nTzF53NuroztRgrbHB394lFrc7XZKur8WQZSwEHeFpA=; b=A90aQDSmTJicxO9zOPubi5b/wVe/V5iGXzga7b9RCrWjWwEIphBUvM8nWbtJvAnqP3 kI9HedBa9Tsb1iCXovKQWNXgdl55FwkVlO4fDuxzpXFBaW4UVZ+FRyGJxKjp+yRTBeLN nFUjoCGc8pjU112JTADeQbj3YbtnskfJDQVmzkaKQnYE2BMv5wo+5Ei0ncVuHYmuA+5C jDA6x3nOmOZy33qLfvKLPGVaUOOYkC62WDq2TA+9G4pk/+RzZcJ4DVDUJ9HDflGFlR5Y vBdqqV9GYN8RZ+KGW28JlssECsmBKZsYJja8UKmYh6fXqGKN5W9tf5EaFwLXSwS4hfem 1h4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719955635; x=1720560435; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nTzF53NuroztRgrbHB394lFrc7XZKur8WQZSwEHeFpA=; b=mZwpV5a6yPfnGolJRisdGacYP0PJnWFUYO/ZtcgmYXY6U0JonWtsoGZY/MhahZnZLs bjIo9IT1Bs0zAJwCEX5/PNiHLaCgPNXRTsfIIeuD+45KuZvT+SyXkX2CAkWeC1apUXT5 g6AyYMi5FQ42aGVmPq6Gg5GamP0fSThZynW00AOAc7fOC7QPtdDh/eLfs1/Hq/sEqPPj kB1tOQelx/Z/C3Eg4ohUv09wd872igf7MQ7/bmDmDReL89uXuQQd4Bg4Kln+b7z64vLO thdEou1jD3t5nFChfziaehcszbKw1WwKwc9sDDFE8lMcFEs6cB6/8l2ZCAfaOlsw3XJp RGlw== X-Forwarded-Encrypted: i=1; AJvYcCXqCdQUtk2+VZP3VPX4ug1Ely1NynPEt9sOxGCKII/s7ftgc38mkJnLkFYHEN+Clo7VfUTHIqOzIZVfKsSBJBOZOQodlknoipA5Pg== X-Gm-Message-State: AOJu0Yyrn+ci5DIx16z60DnANiqMYDgnxmYb3G6FjIRe+QPgpNmcP+6X 2eJyd1Wb3QIBTW/mR+nuhVgD+07/5MIXtN8f9JN4Y9rkwDIrZpY3lQWHD3FIohs= X-Google-Smtp-Source: AGHT+IEXkSehpzi4dO+e44Mjuzyc/L9KJG1nFcAOno11tON/+OnVJMgXU857jRLULOgie6mk2dtQcQ== X-Received: by 2002:a05:6871:b09:b0:254:c41a:2b34 with SMTP id 586e51a60fabf-25db33f824emr8393430fac.22.1719955635025; Tue, 02 Jul 2024 14:27:15 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:a6f1:b7be:4c8c:bf62]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-25d8e37ee64sm2386570fac.47.2024.07.02.14.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 14:27:14 -0700 (PDT) Date: Tue, 2 Jul 2024 23:27:12 +0200 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, iansdannapel@gmail.com, Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Neil Armstrong , Sebastian Reichel , Chris Morgan , Michael Riesch , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andre Przywara , Linus Walleij , linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ian Dannapel Subject: Re: [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver Message-ID: <6286e61c-6822-40d4-a43e-617a4ce257ca@suswa.mountain> Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628152348.61133-2-iansdannapel@gmail.com> Hi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/iansdannapel-gmail-com/fpga-Add-Efinix-Trion-Titanium-serial-SPI-programming-driver/20240630-044745 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20240628152348.61133-2-iansdannapel%40gmail.com patch subject: [PATCH v2 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver config: powerpc-randconfig-r081-20240701 (https://download.01.org/0day-ci/archive/20240703/202407030525.VHF3He6K-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202407030525.VHF3He6K-lkp@intel.com/ smatch warnings: drivers/fpga/efinix-trion-spi-passive.c:174 efinix_spi_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +174 drivers/fpga/efinix-trion-spi-passive.c 4c272ecc14b70f Ian Dannapel 2024-06-28 152 static int efinix_spi_probe(struct spi_device *spi) 4c272ecc14b70f Ian Dannapel 2024-06-28 153 { 4c272ecc14b70f Ian Dannapel 2024-06-28 154 struct efinix_spi_conf *conf; 4c272ecc14b70f Ian Dannapel 2024-06-28 155 struct fpga_manager *mgr; 4c272ecc14b70f Ian Dannapel 2024-06-28 156 4c272ecc14b70f Ian Dannapel 2024-06-28 157 conf = devm_kzalloc(&spi->dev, sizeof(*conf), GFP_KERNEL); 4c272ecc14b70f Ian Dannapel 2024-06-28 158 if (!conf) 4c272ecc14b70f Ian Dannapel 2024-06-28 159 return -ENOMEM; 4c272ecc14b70f Ian Dannapel 2024-06-28 160 4c272ecc14b70f Ian Dannapel 2024-06-28 161 conf->spi = spi; 4c272ecc14b70f Ian Dannapel 2024-06-28 162 4c272ecc14b70f Ian Dannapel 2024-06-28 163 conf->creset = devm_gpiod_get(&spi->dev, "creset", GPIOD_OUT_HIGH); 4c272ecc14b70f Ian Dannapel 2024-06-28 164 if (IS_ERR(conf->creset)) 4c272ecc14b70f Ian Dannapel 2024-06-28 165 return dev_err_probe(&spi->dev, PTR_ERR(conf->creset), 4c272ecc14b70f Ian Dannapel 2024-06-28 166 "Failed to get RESET gpio\n"); 4c272ecc14b70f Ian Dannapel 2024-06-28 167 4c272ecc14b70f Ian Dannapel 2024-06-28 168 conf->cs = devm_gpiod_get(&spi->dev, "cs", GPIOD_OUT_HIGH); 4c272ecc14b70f Ian Dannapel 2024-06-28 169 if (IS_ERR(conf->cs)) 4c272ecc14b70f Ian Dannapel 2024-06-28 170 return dev_err_probe(&spi->dev, PTR_ERR(conf->cs), 4c272ecc14b70f Ian Dannapel 2024-06-28 171 "Failed to get CHIP_SELECT gpio\n"); 4c272ecc14b70f Ian Dannapel 2024-06-28 172 4c272ecc14b70f Ian Dannapel 2024-06-28 173 if (!(spi->mode & SPI_CPHA) || !(spi->mode & SPI_CPOL)) 4c272ecc14b70f Ian Dannapel 2024-06-28 @174 return dev_err_probe(&spi->dev, PTR_ERR(conf->cs), s/conf->cs/-EINVAL/ 4c272ecc14b70f Ian Dannapel 2024-06-28 175 "Unsupported SPI mode, set CPHA and CPOL\n"); 4c272ecc14b70f Ian Dannapel 2024-06-28 176 4c272ecc14b70f Ian Dannapel 2024-06-28 177 conf->cdone = devm_gpiod_get_optional(&spi->dev, "cdone", GPIOD_IN); 4c272ecc14b70f Ian Dannapel 2024-06-28 178 if (IS_ERR(conf->cdone)) 4c272ecc14b70f Ian Dannapel 2024-06-28 179 return dev_err_probe(&spi->dev, PTR_ERR(conf->cdone), 4c272ecc14b70f Ian Dannapel 2024-06-28 180 "Failed to get CDONE gpio\n"); 4c272ecc14b70f Ian Dannapel 2024-06-28 181 4c272ecc14b70f Ian Dannapel 2024-06-28 182 mgr = devm_fpga_mgr_register(&spi->dev, 4c272ecc14b70f Ian Dannapel 2024-06-28 183 "Efinix SPI Passive Programming FPGA Manager", 4c272ecc14b70f Ian Dannapel 2024-06-28 184 &efinix_spi_ops, conf); 4c272ecc14b70f Ian Dannapel 2024-06-28 185 4c272ecc14b70f Ian Dannapel 2024-06-28 186 return PTR_ERR_OR_ZERO(mgr); 4c272ecc14b70f Ian Dannapel 2024-06-28 187 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki