[PATCH 0/2] Add device tree binding for ts73xx-fpga

[PATCH 0/2] Add device tree binding for ts73xx-fpga

[Phil Pemberton]

The driver for the Technologic Systems (EmbeddedTS) TS-7300 board's
onboard FPGA didn't have an OF match table. This prevented it from being
instantiated from a device tree. This is undesirable given EP93xx is
moving to device tree, and effectively prevents it from being used.

This patch series adds the OF match table and a device tree binding.

Phil Pemberton (2):
  dt-bindings: fpga: add binding for Technologic Systems TS-73xx FPGA
  fpga: ts73xx-fpga: add OF match table for device tree probing

 .../fpga/technologic,ts73xx-fpga.yaml         | 42 +++++++++++++++++++
 drivers/fpga/ts73xx-fpga.c                    |  9 ++++
 2 files changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml

-- 
2.43.0

[PATCH 1/2] dt-bindings: fpga: add binding for Technologic Systems TS-73xx FPGA

[Phil Pemberton]

Add device tree binding documentation for the Altera Cyclone II FPGA
found on Technologic Systems TS-7300 series boards, programmed via a
CPLD memory-mapped interface.

Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>
---
 .../fpga/technologic,ts73xx-fpga.yaml         | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml

diff --git a/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
new file mode 100644
index 000000000000..1f7a651e8f10
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fpga/technologic,ts73xx-fpga.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Technologic Systems TS-73xx FPGA Manager
+
+maintainers:
+  - Florian Fainelli <f.fainelli@gmail.com>
+
+description:
+  FPGA manager for the Altera Cyclone II FPGA on Technologic Systems
+  TS-7300 series boards. The FPGA is programmed via a CPLD interface
+  at a memory-mapped register pair.
+
+properties:
+  compatible:
+    const: technologic,ts73xx-fpga
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    bus {
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges;
+
+        fpga-mgr@13c00000 {
+            compatible = "technologic,ts73xx-fpga";
+            reg = <0x13c00000 0x2>;
+        };
+    };
+...
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: fpga: add binding for Technologic Systems TS-73xx FPGA

[Florian Fainelli]

On 4/7/26 10:27, Phil Pemberton wrote:
> Add device tree binding documentation for the Altera Cyclone II FPGA
> found on Technologic Systems TS-7300 series boards, programmed via a
> CPLD memory-mapped interface.
> 
> Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH 1/2] dt-bindings: fpga: add binding for Technologic Systems TS-73xx FPGA

[Krzysztof Kozlowski]

On Tue, Apr 07, 2026 at 06:27:29PM +0100, Phil Pemberton wrote:
> Add device tree binding documentation for the Altera Cyclone II FPGA
> found on Technologic Systems TS-7300 series boards, programmed via a
> CPLD memory-mapped interface.

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>
> ---
>  .../fpga/technologic,ts73xx-fpga.yaml         | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> new file mode 100644
> index 000000000000..1f7a651e8f10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/technologic,ts73xx-fpga.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/technologic,ts73xx-fpga.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Technologic Systems TS-73xx FPGA Manager
> +
> +maintainers:
> +  - Florian Fainelli <f.fainelli@gmail.com>
> +
> +description:
> +  FPGA manager for the Altera Cyclone II FPGA on Technologic Systems
> +  TS-7300 series boards. The FPGA is programmed via a CPLD interface
> +  at a memory-mapped register pair.
> +
> +properties:
> +  compatible:
> +    const: technologic,ts73xx-fpga

So xx is a wildcard? That's not allowed (see writing bindings or any
talks). You need specific compatible. And compatibility, so fallbacks,
if you have multiple distinctive devices.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    bus {
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;

Drop entire node, not needed.

Best regards,
Krzysztof

[PATCH 2/2] fpga: ts73xx-fpga: add OF match table for device tree probing

[Phil Pemberton]

The ts73xx-fpga driver currently only matches by platform device name,
which prevents it from being probed when the device is described in a
device tree. Add an of_device_id table so the driver can match against
the "technologic,ts73xx-fpga" compatible string.

Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>
---
 drivers/fpga/ts73xx-fpga.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
index 4e1d2a4d3df4..5c8a2008d5a2 100644
--- a/drivers/fpga/ts73xx-fpga.c
+++ b/drivers/fpga/ts73xx-fpga.c
@@ -11,6 +11,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/string.h>
 #include <linux/iopoll.h>
@@ -119,9 +120,17 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
 	return PTR_ERR_OR_ZERO(mgr);
 }
 
+static const struct of_device_id ts73xx_fpga_of_match[] = {
+	{ .compatible = "technologic,ts73xx-fpga" },
+	{},
+};
+
+MODULE_DEVICE_TABLE(of, ts73xx_fpga_of_match);
+
 static struct platform_driver ts73xx_fpga_driver = {
 	.driver	= {
 		.name	= "ts73xx-fpga-mgr",
+		.of_match_table = ts73xx_fpga_of_match,
 	},
 	.probe	= ts73xx_fpga_probe,
 };
-- 
2.43.0

Re: [PATCH 2/2] fpga: ts73xx-fpga: add OF match table for device tree probing

[Florian Fainelli]

On 4/7/26 10:27, Phil Pemberton wrote:
> The ts73xx-fpga driver currently only matches by platform device name,
> which prevents it from being probed when the device is described in a
> device tree. Add an of_device_id table so the driver can match against
> the "technologic,ts73xx-fpga" compatible string.
> 
> Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian