From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Charles Perry <charles.perry@savoirfairelinux.com>, mdf@kernel.org
Cc: avandiver@markem-imaje.com, bcody@markem-imaje.com,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
kishore Manne <nava.kishore.manne@amd.com>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios
Date: Sun, 11 Feb 2024 16:39:28 +0100 [thread overview]
Message-ID: <69679d9a-02e9-498f-8f5a-7c029059a8c1@linaro.org> (raw)
In-Reply-To: <20240207180142.79625-3-charles.perry@savoirfairelinux.com>
On 07/02/2024 19:01, Charles Perry wrote:
> By convention, gpio consumer names should not contain underscores
> (prog_b here) and shouldn't contain active low suffixes (-b here).
>
> Signed-off-by: Charles Perry <charles.perry@savoirfairelinux.com>
> ---
> .../bindings/fpga/xlnx,fpga-slave-serial.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> index 614d86ad825f3..650a4d8792b64 100644
> --- a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> @@ -36,7 +36,7 @@ properties:
> reg:
> maxItems: 1
>
> - prog_b-gpios:
> + prog-gpios:
Please deprecate old property and add allOf excluding the usage of both.
Driver still parses old property, so we should have it documented.
https://lore.kernel.org/all/20230118163208.GA117919-robh@kernel.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-11 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 18:01 [PATCH v3 0/5] fpga: xilinx-selectmap: add new driver Charles Perry
2024-02-07 18:01 ` [PATCH v3 1/5] fpga: xilinx-spi: extract a common driver core Charles Perry
2024-02-07 18:01 ` [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios Charles Perry
2024-02-11 15:39 ` Krzysztof Kozlowski [this message]
2024-02-13 21:40 ` Charles Perry
2024-02-15 13:32 ` Rob Herring
2024-02-15 19:42 ` Charles Perry
2024-02-07 18:01 ` [PATCH v3 3/5] fpga: xilinx-core: rename "prog_b" and "init-b" gpios Charles Perry
2024-02-11 15:40 ` Krzysztof Kozlowski
2024-02-07 18:01 ` [PATCH v3 4/5] dt-bindings: fpga: xlnx,fpga-selectmap: add DT schema Charles Perry
2024-02-07 21:25 ` Rob Herring
2024-02-07 18:01 ` [PATCH v3 5/5] fpga: xilinx-selectmap: add new driver Charles Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69679d9a-02e9-498f-8f5a-7c029059a8c1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avandiver@markem-imaje.com \
--cc=bcody@markem-imaje.com \
--cc=charles.perry@savoirfairelinux.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=nava.kishore.manne@amd.com \
--cc=robh+dt@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).