linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: linux-spi@vger.kernel.org, linux-fpga@vger.kernel.org,
	conor@kernel.org, Vladimir Georgiev <v.georgiev@metrotek.ru>,
	Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	valentina.fernandezalanis@microchip.com
Subject: Re: [BUG] microchip-spi programming issue
Date: Tue, 6 Jun 2023 13:04:51 +0100	[thread overview]
Message-ID: <6a01d7c9-8773-4206-bf8a-1f67cfe1dbb0@sirena.org.uk> (raw)
In-Reply-To: <20230606-coyness-camper-45f410b9309f@wendy>

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

On Tue, Jun 06, 2023 at 01:01:01PM +0100, Conor Dooley wrote:
> On Tue, Jun 06, 2023 at 12:55:58PM +0100, Mark Brown wrote:

> > It is obviously going to corrupt the transfer if we deassert chip select
> > without being asked, it is only valid to change it during a message if
> > cs_change is set.

> So, reading between the lines, I shouldn't have doubted myself and this
> is an issue in the SPI controller or its driver?

Yes.  Note that it may be that the hardware is limited and can't do
whatever it's being asked to do.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-06-06 12:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 11:30 [BUG] microchip-spi programming issue Conor Dooley
2023-06-06 11:55 ` Mark Brown
2023-06-06 12:01   ` Conor Dooley
2023-06-06 12:04     ` Mark Brown [this message]
2023-06-07 16:48       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a01d7c9-8773-4206-bf8a-1f67cfe1dbb0@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=v.georgiev@metrotek.ru \
    --cc=valentina.fernandezalanis@microchip.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).