From: Richard Gong <richard.gong@linux.intel.com>
To: Tom Rix <trix@redhat.com>,
mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication
Date: Sat, 14 Nov 2020 08:55:50 -0600 [thread overview]
Message-ID: <6ec8b5ee-9505-7863-fcb6-7e5bbe2aa963@linux.intel.com> (raw)
In-Reply-To: <9bb29416-65fe-85e8-b960-23abc49352f2@redhat.com>
Hi Tom.
On 11/13/20 2:31 PM, Tom Rix wrote:
>
> On 11/12/20 10:06 AM, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Exten FPGA manager driver to support FPGA bitstream authentication on
>> Intel SocFPGA platforms.
>>
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> ---
>> drivers/fpga/stratix10-soc.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
>> index 657a70c..8a59365 100644
>> --- a/drivers/fpga/stratix10-soc.c
>> +++ b/drivers/fpga/stratix10-soc.c
>> @@ -185,7 +185,10 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
>> ctype.flags = 0;
>> if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
>> dev_dbg(dev, "Requesting partial reconfiguration.\n");
>> - ctype.flags |= BIT(COMMAND_RECONFIG_FLAG_PARTIAL);
>> + ctype.flags |= FPGA_MGR_PARTIAL_RECONFIG;
>
> The change does not match the commit log.
>
> Add some comment like..
>
> 'Cleanup setting of partial reconfig flag'
>
> to cover the change.
I will make the cleanup change separately in a different patch.
Regards,
Richard
>
> Tom
>
>> + } else if (info->flags & FPGA_MGR_BITSTREM_AUTHENTICATION) {
>> + dev_dbg(dev, "Requesting bitstream authentication.\n");
>> + ctype.flags |= FPGA_MGR_BITSTREM_AUTHENTICATION;
>> } else {
>> dev_dbg(dev, "Requesting full reconfiguration.\n");
>> }
>
next prev parent reply other threads:[~2020-11-14 14:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 18:06 [PATCHv1 0/4] Extend FPGA manager and region drivers for richard.gong
2020-11-12 18:06 ` [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2020-11-13 20:24 ` Tom Rix
2020-11-14 14:30 ` Richard Gong
2020-11-14 15:53 ` Tom Rix
2020-11-16 13:39 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 2/4] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2020-11-13 20:25 ` Tom Rix
2020-11-12 18:06 ` [PATCHv1 3/4] dt-bindings: fpga: " richard.gong
2020-11-13 20:28 ` Tom Rix
2020-11-14 14:52 ` Richard Gong
2020-11-14 15:59 ` Tom Rix
2020-11-16 13:50 ` Richard Gong
2020-11-16 15:11 ` Tom Rix
2020-11-15 19:21 ` Moritz Fischer
2020-11-16 2:47 ` Xu Yilun
2020-11-16 14:14 ` Richard Gong
2020-11-17 2:24 ` Xu Yilun
2020-11-17 15:39 ` Richard Gong
2020-11-18 5:47 ` Xu Yilun
2020-11-18 13:38 ` Richard Gong
2020-11-19 11:14 ` Xu Yilun
2020-11-16 13:59 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication richard.gong
2020-11-13 20:31 ` Tom Rix
2020-11-14 14:55 ` Richard Gong [this message]
2020-11-15 19:19 ` Moritz Fischer
2020-11-16 14:39 ` Richard Gong
2020-11-16 2:41 ` [PATCHv1 0/4] Extend FPGA manager and region drivers for Xu Yilun
2020-11-16 14:02 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec8b5ee-9505-7863-fcb6-7e5bbe2aa963@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=dinguyen@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=sridhar.rajagopal@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).