From: Tom Rix <trix@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
hao.wu@intel.com, mdf@kernel.org, corbet@lwn.net
Cc: linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/1] fpga: dfl: RFC PCI config
Date: Tue, 30 Jun 2020 11:44:16 -0700 [thread overview]
Message-ID: <78a250ab-29ad-f7cb-3fa2-482e76db207a@redhat.com> (raw)
In-Reply-To: <67f7f2b8-3567-aadd-30d6-4cfbc0bc8ce5@infradead.org>
> I haven't tested this, but in general it's not safe to select something like
> SENSORS* or HWMON* unless you first check that CONFIG_HWMON is enabled.
> Otherwise this would usually cause kconfig warning(s).
>
> But don't add things like
> select HWMON
> select SPI
> select SPI_MASTER
>
> because we don't enable subsystems (like HWMON or SPI) just inside one
> driver's kconfig entry.
> The driver(s) should instead depend on HWMON, SPI, SPI_MASTER etc.
Yes, I thought this was ugly. The next rev addresses this issue. The config will not be fully automagic. User will have enough information in the doc to figure out the other subsystems.
Tom
prev parent reply other threads:[~2020-06-30 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 17:16 [RFC 0/1] fpga: dfl: RFC PCI config trix
2020-06-30 17:16 ` [RFC 1/1] " trix
2020-06-30 17:26 ` Randy Dunlap
2020-06-30 18:44 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a250ab-29ad-f7cb-3fa2-482e76db207a@redhat.com \
--to=trix@redhat.com \
--cc=corbet@lwn.net \
--cc=hao.wu@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).