From: Michal Simek <michal.simek@xilinx.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
julia.lawall@lip6.fr, atull@kernel.org, mdf@kernel.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
Date: Tue, 29 Aug 2017 08:00:20 +0200 [thread overview]
Message-ID: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> (raw)
In-Reply-To: <1503941531-17977-1-git-send-email-bhumirks@gmail.com>
On 28.8.2017 19:32, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> fpga_bridge_register.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index e359930..0d77430 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
> return !status;
> }
>
> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> .enable_set = xlnx_pr_decoupler_enable_set,
> .enable_show = xlnx_pr_decoupler_enable_show,
> };
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
prev parent reply other threads:[~2017-08-29 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 17:32 [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Bhumika Goyal
2017-08-29 6:00 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=atull@kernel.org \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).