From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of_node() helper References: <1560534863-15115-1-git-send-email-suzuki.poulose@arm.com> <1560534863-15115-14-git-send-email-suzuki.poulose@arm.com> <325e46fd-a480-78ed-81fd-55e993fbc06f@axentia.se> <5cf1a8e2-bb1e-b6bc-32fe-93db0a6b5efd@arm.com> <528dcb2e-3611-00a7-abb2-cc18001f4f8f@axentia.se> From: Suzuki K Poulose Message-ID: <8c8f447d-71a9-0420-590d-94710131c69d@arm.com> Date: Mon, 24 Jun 2019 16:19:42 +0100 MIME-Version: 1.0 In-Reply-To: <528dcb2e-3611-00a7-abb2-cc18001f4f8f@axentia.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: peda@axentia.se, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, atull@kernel.org, mdf@kernel.org, linux-fpga@vger.kernel.org, broonie@kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, andrew@lunn.ch, lgirdwood@gmail.com, jslaby@suse.com List-ID: On 24/06/2019 15:07, Peter Rosin wrote: > On 2019-06-24 10:34, Suzuki K Poulose wrote: >> Hi Peter, >> >> On 22/06/2019 06:25, Peter Rosin wrote: >>> On 2019-06-14 19:54, Suzuki K Poulose wrote: >>>> Add a wrapper to class_find_device() to search for a device >>>> by the of_node pointer, reusing the generic match function. >>>> Also convert the existing users to make use of the new helper. >>>> >>>> Cc: Alan Tull >>>> Cc: Moritz Fischer >>>> Cc: linux-fpga@vger.kernel.org >>>> Cc: Peter Rosin >>>> Cc: Mark Brown >>>> Cc: Florian Fainelli >>>> Cc: Heiner Kallweit >>>> Cc: "David S. Miller" >>>> Cc: Andrew Lunn >>>> Cc: Liam Girdwood >>>> Cc: Greg Kroah-Hartman >>>> Cc: "Rafael J. Wysocki" >>>> Cc: Jiri Slaby >>>> Acked-by: Mark Brown >>>> Reviewed-by: Andrew Lunn >>>> Reviewed-by: Peter Rosin >>> >>> Whoooa! I reviewed only the drivers/mux/core.c changes when this was done >>> in a series of much smaller patches. This tag makes it seem as if I have >>> reviewed the whole thing, which I had not done when you added this tag out >>> of the blue. >> >> Apologies for the surprise. The patch was simply squashed with the change that >> introduced the "helper" to better aid the reviewers, based on suggestions on the >> list. I kept your tags, only because there were no changes, but some additional >> context on the core driver. > > You could e.g. have written: > > ... > [For the drivers/mux/core.c part] > Reviewed-by: Peter Rosin > ... Ok. This might change again, another level of merging, but no changes to the hunk for mux. So I can use the above. Cheers Suzuki