From: "NG, TZE YEE" <tze.yee.ng@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: stratix10-soc: Fix SVC mailbox handling during reconfiguration
Date: Wed, 24 Jun 2026 03:20:56 +0000 [thread overview]
Message-ID: <8d978dfd-08ed-4003-a744-458a82345756@altera.com> (raw)
In-Reply-To: <da50ce16-f1a8-4d2e-8abd-ee9900644752@kernel.org>
On 24/6/2026 12:09 am, Dinh Nguyen wrote:
>
>
> On 6/23/26 04:47, tze.yee.ng@altera.com wrote:
>> From: Tien Sung Ang <tien.sung.ang@altera.com>
>>
>> Fix incorrect stratix10_svc_done() usage during FPGA reconfiguration.
>
> Do you need a Fixes tag and Cc: stable then?
>
Yes. The incorrect stratix10_svc_done() call in write_init() has been
there since the driver was first added. I'll add the following fixes tag
in v2:
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Cc: stable@vger.kernel.org # 5.1+
>>
>> Do not call stratix10_svc_done() at the end of write_init() on
>> success, so
>> the SVC session remains active through write() and write_complete(). Call
>> stratix10_svc_done() on failure in write_init() and write() so the shared
>> SVC mailbox is released when reconfiguration aborts, allowing coexistence
>> with other SVC clients such as soc64-hwmon.
>>
>
prev parent reply other threads:[~2026-06-24 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 9:47 [PATCH] fpga: stratix10-soc: Fix SVC mailbox handling during reconfiguration tze.yee.ng
2026-06-23 16:09 ` Dinh Nguyen
2026-06-24 3:20 ` NG, TZE YEE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d978dfd-08ed-4003-a744-458a82345756@altera.com \
--to=tze.yee.ng@altera.com \
--cc=dinguyen@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox