From: Tom Rix <trix@redhat.com>
To: Xu Yilun <yilun.xu@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
lgoncalv@redhat.com, hao.wu@intel.com
Subject: Re: [PATCH v2 2/2] Documentation: fpga: dfl: Add description for DFL UIO support
Date: Mon, 14 Dec 2020 20:43:31 -0800 [thread overview]
Message-ID: <97d06583-ca99-67ae-55e1-ff714b47f8cb@redhat.com> (raw)
In-Reply-To: <20201215022206.GC14854@yilunxu-OptiPlex-7050>
On 12/14/20 6:22 PM, Xu Yilun wrote:
> On Mon, Dec 14, 2020 at 02:14:56PM -0800, Tom Rix wrote:
>> On 12/13/20 7:36 PM, Xu Yilun wrote:
>>> This patch adds description for UIO support for dfl devices on DFL
>>> bus.
>>>
>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
>>> ---
>>> v2: no doc in v1, add it for v2.
>>> ---
>>
>>> +components. They could instantiate a new private feature in the DFL, and then
>>> +get a DFL device in their system. In some cases users may need a userspace
>>> +driver for the DFL device:
>>> +
>>> +* Users may need to run some diagnostic test for their hardwares.
>> * Users may prototype the kernel driver in user space.
> Could we just add the line rather than replacing the previous line? I think this
> comment is describing a different usecase.
Yes, this is what i ment, please use your original.
I am offering another usecase, one I will use.
Add mine as well, if you want.
>
>>> +* Some hardware is designed for specific purposes and does not fit into one of
>>> + the standard kernel subsystems.
>>> +
>>> +This requires the direct access to the MMIO space and interrupt handling in
>>> +userspace. We implemented a dfl-uio-pdev module which exposes the UIO device
>> The dfl-uio-pdev module exposes
> Will change it.
>
>>> +interfaces. It adds the uio_pdrv_genirq platform device with the resources of
>>> +the DFL device, and let the generic UIO platform device driver provide UIO
>> the DLF device, and lets
> Will change it.
>
>>> +support to userspace.
>> Use FPGA_DFL_UIO_PDEV to enable this feature.
> I didn't get your idea for this.
I wanted the user to know which kconfig controls this feature.
Leave it out if you don't think it fits.
>
>>> +
>>> +The DFL UIO driver has a special matching algorithem. It will match any DFL
>>> +device which could not be handled by other DFL drivers. In this way, it will
>>> +not impact the functionality of the features which are already supported by the
>>> +system.
>> (not sure if this section is needed)
> I think we may keep it.
Ok.
Tom
>
> Thanks,
> Yilun
>
next prev parent reply other threads:[~2020-12-15 4:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 3:36 [PATCH v2 0/2] UIO support for dfl devices Xu Yilun
2020-12-14 3:36 ` [PATCH v2 1/2] fpga: dfl: add the userspace I/O device support for DFL devices Xu Yilun
2020-12-14 22:03 ` Tom Rix
2020-12-15 2:06 ` Xu Yilun
2020-12-14 3:36 ` [PATCH v2 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Xu Yilun
2020-12-14 22:14 ` Tom Rix
2020-12-15 2:22 ` Xu Yilun
2020-12-15 4:43 ` Tom Rix [this message]
2020-12-15 5:15 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97d06583-ca99-67ae-55e1-ff714b47f8cb@redhat.com \
--to=trix@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).