* [PATCH] fpga: remove redundant checks for bridge ops
@ 2024-01-24 15:24 Marco Pagani
2024-01-30 9:18 ` Xu Yilun
0 siblings, 1 reply; 3+ messages in thread
From: Marco Pagani @ 2024-01-24 15:24 UTC (permalink / raw)
To: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix
Cc: Marco Pagani, linux-fpga, linux-kernel
Commit 0d70af3c2530 ("fpga: bridge: Use standard dev_release for class
driver") introduced a check in fpga_bridge_register() that prevents
registering a bridge without ops, making checking on every call
redundant.
Signed-off-by: Marco Pagani <marpagan@redhat.com>
---
drivers/fpga/fpga-bridge.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
index a024be2b84e2..e0a5ef318f5e 100644
--- a/drivers/fpga/fpga-bridge.c
+++ b/drivers/fpga/fpga-bridge.c
@@ -30,7 +30,7 @@ int fpga_bridge_enable(struct fpga_bridge *bridge)
{
dev_dbg(&bridge->dev, "enable\n");
- if (bridge->br_ops && bridge->br_ops->enable_set)
+ if (bridge->br_ops->enable_set)
return bridge->br_ops->enable_set(bridge, 1);
return 0;
@@ -48,7 +48,7 @@ int fpga_bridge_disable(struct fpga_bridge *bridge)
{
dev_dbg(&bridge->dev, "disable\n");
- if (bridge->br_ops && bridge->br_ops->enable_set)
+ if (bridge->br_ops->enable_set)
return bridge->br_ops->enable_set(bridge, 0);
return 0;
@@ -401,7 +401,7 @@ void fpga_bridge_unregister(struct fpga_bridge *bridge)
* If the low level driver provides a method for putting bridge into
* a desired state upon unregister, do it.
*/
- if (bridge->br_ops && bridge->br_ops->fpga_bridge_remove)
+ if (bridge->br_ops->fpga_bridge_remove)
bridge->br_ops->fpga_bridge_remove(bridge);
device_unregister(&bridge->dev);
base-commit: c849ecb2ae8413f86c84627cb0af06dffce4e215
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: remove redundant checks for bridge ops
2024-01-24 15:24 [PATCH] fpga: remove redundant checks for bridge ops Marco Pagani
@ 2024-01-30 9:18 ` Xu Yilun
2024-02-01 15:14 ` Marco Pagani
0 siblings, 1 reply; 3+ messages in thread
From: Xu Yilun @ 2024-01-30 9:18 UTC (permalink / raw)
To: Marco Pagani
Cc: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga,
linux-kernel
On Wed, Jan 24, 2024 at 04:24:07PM +0100, Marco Pagani wrote:
> Commit 0d70af3c2530 ("fpga: bridge: Use standard dev_release for class
> driver") introduced a check in fpga_bridge_register() that prevents
> registering a bridge without ops, making checking on every call
> redundant.
>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
> drivers/fpga/fpga-bridge.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> index a024be2b84e2..e0a5ef318f5e 100644
> --- a/drivers/fpga/fpga-bridge.c
> +++ b/drivers/fpga/fpga-bridge.c
> @@ -30,7 +30,7 @@ int fpga_bridge_enable(struct fpga_bridge *bridge)
> {
> dev_dbg(&bridge->dev, "enable\n");
>
> - if (bridge->br_ops && bridge->br_ops->enable_set)
> + if (bridge->br_ops->enable_set)
> return bridge->br_ops->enable_set(bridge, 1);
>
> return 0;
> @@ -48,7 +48,7 @@ int fpga_bridge_disable(struct fpga_bridge *bridge)
> {
> dev_dbg(&bridge->dev, "disable\n");
>
> - if (bridge->br_ops && bridge->br_ops->enable_set)
> + if (bridge->br_ops->enable_set)
> return bridge->br_ops->enable_set(bridge, 0);
>
> return 0;
> @@ -401,7 +401,7 @@ void fpga_bridge_unregister(struct fpga_bridge *bridge)
> * If the low level driver provides a method for putting bridge into
> * a desired state upon unregister, do it.
> */
> - if (bridge->br_ops && bridge->br_ops->fpga_bridge_remove)
> + if (bridge->br_ops->fpga_bridge_remove)
> bridge->br_ops->fpga_bridge_remove(bridge);
Also for state_show()?
Thanks,
Yilun
>
> device_unregister(&bridge->dev);
>
> base-commit: c849ecb2ae8413f86c84627cb0af06dffce4e215
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: remove redundant checks for bridge ops
2024-01-30 9:18 ` Xu Yilun
@ 2024-02-01 15:14 ` Marco Pagani
0 siblings, 0 replies; 3+ messages in thread
From: Marco Pagani @ 2024-02-01 15:14 UTC (permalink / raw)
To: Xu Yilun
Cc: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga,
linux-kernel
On 2024-01-30 10:18, Xu Yilun wrote:
> On Wed, Jan 24, 2024 at 04:24:07PM +0100, Marco Pagani wrote:
>> Commit 0d70af3c2530 ("fpga: bridge: Use standard dev_release for class
>> driver") introduced a check in fpga_bridge_register() that prevents
>> registering a bridge without ops, making checking on every call
>> redundant.
>>
>> Signed-off-by: Marco Pagani <marpagan@redhat.com>
>> ---
>> drivers/fpga/fpga-bridge.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
>> index a024be2b84e2..e0a5ef318f5e 100644
>> --- a/drivers/fpga/fpga-bridge.c
>> +++ b/drivers/fpga/fpga-bridge.c
>> @@ -30,7 +30,7 @@ int fpga_bridge_enable(struct fpga_bridge *bridge)
>> {
>> dev_dbg(&bridge->dev, "enable\n");
>>
>> - if (bridge->br_ops && bridge->br_ops->enable_set)
>> + if (bridge->br_ops->enable_set)
>> return bridge->br_ops->enable_set(bridge, 1);
>>
>> return 0;
>> @@ -48,7 +48,7 @@ int fpga_bridge_disable(struct fpga_bridge *bridge)
>> {
>> dev_dbg(&bridge->dev, "disable\n");
>>
>> - if (bridge->br_ops && bridge->br_ops->enable_set)
>> + if (bridge->br_ops->enable_set)
>> return bridge->br_ops->enable_set(bridge, 0);
>>
>> return 0;
>> @@ -401,7 +401,7 @@ void fpga_bridge_unregister(struct fpga_bridge *bridge)
>> * If the low level driver provides a method for putting bridge into
>> * a desired state upon unregister, do it.
>> */
>> - if (bridge->br_ops && bridge->br_ops->fpga_bridge_remove)
>> + if (bridge->br_ops->fpga_bridge_remove)
>> bridge->br_ops->fpga_bridge_remove(bridge);
>
> Also for state_show()?
Right, I missed that one. I'll remove it in v2
Thanks,
Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 15:24 [PATCH] fpga: remove redundant checks for bridge ops Marco Pagani
2024-01-30 9:18 ` Xu Yilun
2024-02-01 15:14 ` Marco Pagani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).