linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency
@ 2025-06-13  9:24 Kuhanh Murugasen Krishnan
  2025-06-13 14:30 ` Matthew Gerlach
  2025-07-10  2:13 ` Xu Yilun
  0 siblings, 2 replies; 3+ messages in thread
From: Kuhanh Murugasen Krishnan @ 2025-06-13  9:24 UTC (permalink / raw)
  To: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga,
	linux-kernel, Kuhanh Murugasen Krishnan,
	Kuhanh Murugasen Krishnan, Khairul Anuar Romli

From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>

Altera CvP FPGA Manager driver depends on FPGA
Configuration Framework drivers to be loaded in
the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
depends on to include FPGA.

Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
---
 drivers/fpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 37b35f58f0df..6f741348bfbc 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
 
 config FPGA_MGR_ALTERA_CVP
 	tristate "Altera CvP FPGA Manager"
-	depends on PCI
+	depends on PCI && FPGA
 	help
 	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
 	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency
  2025-06-13  9:24 [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency Kuhanh Murugasen Krishnan
@ 2025-06-13 14:30 ` Matthew Gerlach
  2025-07-10  2:13 ` Xu Yilun
  1 sibling, 0 replies; 3+ messages in thread
From: Matthew Gerlach @ 2025-06-13 14:30 UTC (permalink / raw)
  To: Kuhanh Murugasen Krishnan, Moritz Fischer, Wu Hao, Xu Yilun,
	Tom Rix, linux-fpga, linux-kernel, Kuhanh Murugasen Krishnan,
	Khairul Anuar Romli



On 6/13/25 2:24 AM, Kuhanh Murugasen Krishnan wrote:
> From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>
Hi Murugasen Krishnan,

You should check your .gitconfig because your patch was from 
kuhanh.murugasen.krishnan@intel.com, but your Signed-off-by: says 
altera.com.

Matthew Gerlach
>
> Altera CvP FPGA Manager driver depends on FPGA
> Configuration Framework drivers to be loaded in
> the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
> depends on to include FPGA.
>
> Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
> ---
>   drivers/fpga/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 37b35f58f0df..6f741348bfbc 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
>   
>   config FPGA_MGR_ALTERA_CVP
>   	tristate "Altera CvP FPGA Manager"
> -	depends on PCI
> +	depends on PCI && FPGA
>   	help
>   	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
>   	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency
  2025-06-13  9:24 [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency Kuhanh Murugasen Krishnan
  2025-06-13 14:30 ` Matthew Gerlach
@ 2025-07-10  2:13 ` Xu Yilun
  1 sibling, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2025-07-10  2:13 UTC (permalink / raw)
  To: Kuhanh Murugasen Krishnan
  Cc: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga,
	linux-kernel, Kuhanh Murugasen Krishnan, Khairul Anuar Romli

On Fri, Jun 13, 2025 at 05:24:14PM +0800, Kuhanh Murugasen Krishnan wrote:
> From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>
> 
> Altera CvP FPGA Manager driver depends on FPGA
> Configuration Framework drivers to be loaded in
> the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
> depends on to include FPGA.

Is that necessary? We've already included all FPGA drivers in "if FPGA".

Thanks,
Yilun

> 
> Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
> ---
>  drivers/fpga/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 37b35f58f0df..6f741348bfbc 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
>  
>  config FPGA_MGR_ALTERA_CVP
>  	tristate "Altera CvP FPGA Manager"
> -	depends on PCI
> +	depends on PCI && FPGA
>  	help
>  	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
>  	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.
> -- 
> 2.25.1
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-10  2:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-13  9:24 [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency Kuhanh Murugasen Krishnan
2025-06-13 14:30 ` Matthew Gerlach
2025-07-10  2:13 ` Xu Yilun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).