linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Moritz Fischer <moritz.fischer@ettus.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: Alan Tull <atull@kernel.org>, linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: xilinx-spi: Use unique FPGA manager names
Date: Thu, 1 Nov 2018 12:44:03 -0700	[thread overview]
Message-ID: <CAAtXAHcv_=CEKdDsQH59-OrPaHO2CUPAYF89ce=kP6WX_UUCeg@mail.gmail.com> (raw)
In-Reply-To: <20181101202325.3bf87ea3@crub>

Hi Anatolij,

On Thu, Nov 1, 2018 at 12:23 PM Anatolij Gustschin <agust@denx.de> wrote:
>
> On Thu, 1 Nov 2018 13:46:27 -0500
> Alan Tull atull@kernel.org wrote:
> ...
> >> # ls -l /sys/class/fpga_manager/fpga0/device
> >> lrwxrwxrwx 1 root root 0 Nov  1 19:26 /sys/class/fpga_manager/fpga0/device -> ../../../spi1.0
> >
> >Is 'device' giving the info this patch is adding to 'name'?
>
> One can extract this info from 'device' somehow, but it is much more
> easier to get it from the name
>
> # cat /sys/class/fpga_manager/fpga0/name
> xlnx-slave-spi spi1.0

I see your use case, but I don't think the FPGA Manager framework is
the right place to fix this,
especially not encoding bus information in the FPGA Manager name. The
info is already available
to userland (not conveniently I agree, but nevertheless).

From my end NAK.

Thanks,

Moritz

      reply	other threads:[~2018-11-02  4:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 14:42 [PATCH] fpga: xilinx-spi: Use unique FPGA manager names Anatolij Gustschin
2018-10-29 16:48 ` Moritz Fischer
2018-10-30 11:19   ` Anatolij Gustschin
2018-11-01 18:21     ` Alan Tull
2018-11-01 18:33       ` Anatolij Gustschin
2018-11-01 18:46         ` Alan Tull
2018-11-01 19:23           ` Anatolij Gustschin
2018-11-01 19:44             ` Moritz Fischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAtXAHcv_=CEKdDsQH59-OrPaHO2CUPAYF89ce=kP6WX_UUCeg@mail.gmail.com' \
    --to=moritz.fischer@ettus.com \
    --cc=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).