From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=aa2N=QA=vger.kernel.org=linux-fpga-owner@kernel.org>
Return-Path: <SRS0=aa2N=QA=vger.kernel.org=linux-fpga-owner@kernel.org>
Received: from mail-yw1-f68.google.com ([209.85.161.68]:46620 "EHLO
        mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727765AbfAXRcR (ORCPT
        <rfc822;linux-fpga@vger.kernel.org>); Thu, 24 Jan 2019 12:32:17 -0500
Received: by mail-yw1-f68.google.com with SMTP id t13so2720627ywe.13
        for <linux-fpga@vger.kernel.org>; Thu, 24 Jan 2019 09:32:16 -0800 (PST)
MIME-Version: 1.0
References: <20181129231016.4580-1-colin.king@canonical.com> <CANk1AXRP-65fK48vqQ+Dy9-cz-4XQ1bWNyDCvzJK8rkoA2F24g@mail.gmail.com>
In-Reply-To: <CANk1AXRP-65fK48vqQ+Dy9-cz-4XQ1bWNyDCvzJK8rkoA2F24g@mail.gmail.com>
From: Moritz Fischer <moritz.fischer@ettus.com>
Date: Thu, 24 Jan 2019 09:22:54 -0800
Message-ID: <CAAtXAHf-_5_aFdkpa5LtnQvy6ddxYwrnXcK9QBkrrP1gkRvLtA@mail.gmail.com>
Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static,
 shrinks object size
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fpga-owner@vger.kernel.org
List-Id: linux-fpga@vger.kernel.org
To: Alan Tull <atull@kernel.org>
Cc: Colin King <colin.king@canonical.com>, linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>

Hi Colin,

sorry dropped of my radar.

On Thu, Jan 24, 2019 at 9:17 AM Alan Tull <atull@kernel.org> wrote:
>
> On Thu, Nov 29, 2018 at 5:10 PM Colin King <colin.king@canonical.com> wrote:
>
> Hi Colin,
>
> Thanks!
>
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Don't populate the const array dummy on the stack but instead
> > make it static. Makes the object code smaller by 26 bytes:
> >
> > Before:
> >    text    data     bss     dec     hex filename
> >    7371    2032       0    9403    24bb drivers/fpga/altera-ps-spi.o
> >
> > After:
> >    text    data     bss     dec     hex filename
> >    7281    2096       0    9377    24a1 drivers/fpga/altera-ps-spi.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>

>
>
> > ---
> >  drivers/fpga/altera-ps-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> > index 8c18beec6b57..678d0115f840 100644
> > --- a/drivers/fpga/altera-ps-spi.c
> > +++ b/drivers/fpga/altera-ps-spi.c
> > @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> >                                     struct fpga_image_info *info)
> >  {
> >         struct altera_ps_conf *conf = mgr->priv;
> > -       const char dummy[] = {0};
> > +       static const char dummy[] = {0};
> >         int ret;
> >
> >         if (gpiod_get_value_cansleep(conf->status)) {
> > --
> > 2.19.1
> >

Moritz