From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 Sender: geert.uytterhoeven@gmail.com In-Reply-To: References: <1521208314-4783-1-git-send-email-geert@linux-m68k.org> <1521208314-4783-11-git-send-email-geert@linux-m68k.org> From: Geert Uytterhoeven Date: Tue, 20 Mar 2018 11:09:06 +0100 Message-ID: Subject: Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency Content-Type: text/plain; charset="UTF-8" To: Madalin-cristian Bucur Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Felipe Balbi , Greg Kroah-Hartman , "James E . J . Bottomley" , "Martin K . Petersen" , Andrew Morton , Mark Brown , Liam Girdwood , Tejun Heo , Herbert Xu , "David S . Miller" , Bartlomiej Zolnierkiewicz , Stefan Richter , Alan Tull , Moritz Fischer , Wolfram Sang , Jonathan Cameron , Joerg Roedel , Matias Bjorling , Jassi Brar , Mauro Carvalho Chehab , Ulf Hansson , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Boris Brezillon , Richard Weinberger , Kalle Valo , Ohad Ben-Cohen , Bjorn Andersson , Eric Anholt , Stefan Wahren , "iommu@lists.linux-foundation.org" , "linux-usb@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-ide@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "linux1394-devel@lists.sourceforge.net" , "linux-fpga@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-spi@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" List-ID: Hi Madalin-cristian, On Mon, Mar 19, 2018 at 6:27 AM, Madalin-cristian Bucur wrote: >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] >> On Behalf Of Geert Uytterhoeven >> Remove dependencies on HAS_DMA where a Kconfig symbol depends on >> another >> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >> In most cases this other symbol is an architecture or platform specific >> symbol, or PCI. >> >> Generic symbols and drivers without platform dependencies keep their >> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >> cannot work anyway. >> >> This simplifies the dependencies, and allows to improve compile-testing. >> >> Notes: >> - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(), >> which does not exist if HAS_DMA=n (Do we need a dummy? The use of >> set_dma_ops() in this driver is questionable), > > Hi, > > The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it. Thank you, looking forward to it! >> - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their >> dependency on HAS_DMA, as they are selected from >> SND_SOC_APQ8016_SBC. >> >> Signed-off-by: Geert Uytterhoeven >> Reviewed-by: Mark Brown >> Acked-by: Robin Murphy Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds