* [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
@ 2018-02-01 22:20 Anatolij Gustschin
2018-02-12 16:02 ` Alan Tull
2018-02-14 23:05 ` Moritz Fischer
0 siblings, 2 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2018-02-01 22:20 UTC (permalink / raw)
To: linux-fpga; +Cc: Alan Tull, Moritz Fischer, Joshua Clayton
If the driver module is loaded when FPGA is configured, the FPGA
is reset because nconfig is pulled low (low-active gpio inited
with GPIOD_OUT_HIGH activates the signal which means setting its
value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
drivers/fpga/altera-ps-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index c593f33d8db9..6891933d072d 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -258,7 +258,7 @@ static int altera_ps_probe(struct spi_device *spi)
}
conf->spi = spi;
- conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
+ conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
if (IS_ERR(conf->config)) {
dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
PTR_ERR(conf->config));
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
2018-02-01 22:20 [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Anatolij Gustschin
@ 2018-02-12 16:02 ` Alan Tull
2018-02-14 23:05 ` Moritz Fischer
1 sibling, 0 replies; 6+ messages in thread
From: Alan Tull @ 2018-02-12 16:02 UTC (permalink / raw)
To: Anatolij Gustschin; +Cc: linux-fpga, Moritz Fischer, Joshua Clayton
On Thu, Feb 1, 2018 at 4:20 PM, Anatolij Gustschin <agust@denx.de> wrote:
Hi Anatolij,
> If the driver module is loaded when FPGA is configured, the FPGA
> is reset because nconfig is pulled low (low-active gpio inited
> with GPIOD_OUT_HIGH activates the signal which means setting its
> value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
Yes, makes sense.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Alan Tull <atull@kernel.org>
Thanks,
Alan
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index c593f33d8db9..6891933d072d 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -258,7 +258,7 @@ static int altera_ps_probe(struct spi_device *spi)
> }
>
> conf->spi = spi;
> - conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
> + conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
> if (IS_ERR(conf->config)) {
> dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
> PTR_ERR(conf->config));
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
2018-02-01 22:20 [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Anatolij Gustschin
2018-02-12 16:02 ` Alan Tull
@ 2018-02-14 23:05 ` Moritz Fischer
1 sibling, 0 replies; 6+ messages in thread
From: Moritz Fischer @ 2018-02-14 23:05 UTC (permalink / raw)
To: Anatolij Gustschin; +Cc: linux-fpga, Alan Tull, Moritz Fischer, Joshua Clayton
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
Hi Anatolij,
On Thu, Feb 01, 2018 at 11:20:04PM +0100, Anatolij Gustschin wrote:
> If the driver module is loaded when FPGA is configured, the FPGA
> is reset because nconfig is pulled low (low-active gpio inited
> with GPIOD_OUT_HIGH activates the signal which means setting its
> value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index c593f33d8db9..6891933d072d 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -258,7 +258,7 @@ static int altera_ps_probe(struct spi_device *spi)
> }
>
> conf->spi = spi;
> - conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
> + conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
> if (IS_ERR(conf->config)) {
> dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
> PTR_ERR(conf->config));
> --
> 2.11.0
>
Thanks for your patch,
Moritz
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
@ 2018-04-15 18:33 Moritz Fischer
2018-04-16 8:10 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Moritz Fischer @ 2018-04-15 18:33 UTC (permalink / raw)
To: gregkh; +Cc: atull, linux-fpga, linux-kernel, Anatolij Gustschin,
Moritz Fischer
From: Anatolij Gustschin <agust@denx.de>
If the driver module is loaded when FPGA is configured, the FPGA
is reset because nconfig is pulled low (low-active gpio inited
with GPIOD_OUT_HIGH activates the signal which means setting its
value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
Hi Greg,
as discussed. Can you please take this bugfix for 4.17?
I rebased it against next.
Thanks,
Moritz
PS: Sorry for late submission
---
drivers/fpga/altera-ps-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 14f14efdf0d5..06d212a3d49d 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -249,7 +249,7 @@ static int altera_ps_probe(struct spi_device *spi)
conf->data = of_id->data;
conf->spi = spi;
- conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
+ conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
if (IS_ERR(conf->config)) {
dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
PTR_ERR(conf->config));
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
2018-04-15 18:33 Moritz Fischer
@ 2018-04-16 8:10 ` Greg KH
2018-04-16 8:34 ` Anatolij Gustschin
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-04-16 8:10 UTC (permalink / raw)
To: Moritz Fischer; +Cc: atull, linux-fpga, linux-kernel, Anatolij Gustschin
On Sun, Apr 15, 2018 at 11:33:08AM -0700, Moritz Fischer wrote:
> From: Anatolij Gustschin <agust@denx.de>
>
> If the driver module is loaded when FPGA is configured, the FPGA
> is reset because nconfig is pulled low (low-active gpio inited
> with GPIOD_OUT_HIGH activates the signal which means setting its
> value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Acked-by: Alan Tull <atull@kernel.org>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>
> Hi Greg,
>
> as discussed. Can you please take this bugfix for 4.17?
> I rebased it against next.
Is it also needed in any older kernel versions?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
2018-04-16 8:10 ` Greg KH
@ 2018-04-16 8:34 ` Anatolij Gustschin
0 siblings, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2018-04-16 8:34 UTC (permalink / raw)
To: Greg KH; +Cc: Moritz Fischer, atull, linux-fpga, linux-kernel
On Mon, 16 Apr 2018 10:10:08 +0200
Greg KH gregkh@linuxfoundation.org wrote:
...
>> as discussed. Can you please take this bugfix for 4.17?
>> I rebased it against next.
>
>Is it also needed in any older kernel versions?
It is needed in versions starting from v4.14.
thanks,
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-16 8:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-01 22:20 [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Anatolij Gustschin
2018-02-12 16:02 ` Alan Tull
2018-02-14 23:05 ` Moritz Fischer
-- strict thread matches above, loose matches on Subject: below --
2018-04-15 18:33 Moritz Fischer
2018-04-16 8:10 ` Greg KH
2018-04-16 8:34 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).