Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

[Moritz Fischer]

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: linux-fpga@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-By: Moritz Fischer <mdf@kernel.org>
> ---
>  drivers/fpga/altera-hps2fpga.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b805f2d07..a18ff430c9af1 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>  	of_id = of_match_device(altera_fpga_of_match, dev);
>  	priv = (struct altera_hps2fpga_data *)of_id->data;
>  
> -	priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> +	priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> +								     0);
>  	if (IS_ERR(priv->bridge_reset)) {
>  		dev_err(dev, "Could not get %s reset control\n", priv->name);
>  		return PTR_ERR(priv->bridge_reset);
> -- 
> 2.11.0
> 

Thanks,

Moritz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

[Alan Tull]

On Wed, Jul 19, 2017 at 11:12 AM, Moritz Fischer <mdf@kernel.org> wrote:
> On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Acked-By: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>