* [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
@ 2018-11-29 23:10 Colin King
2019-01-24 16:49 ` Colin Ian King
2019-01-24 17:16 ` Alan Tull
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2018-11-29 23:10 UTC (permalink / raw)
To: Alan Tull, Moritz Fischer, linux-fpga; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array dummy on the stack but instead
make it static. Makes the object code smaller by 26 bytes:
Before:
text data bss dec hex filename
7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
After:
text data bss dec hex filename
7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
(gcc version 8.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/fpga/altera-ps-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 8c18beec6b57..678d0115f840 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
struct fpga_image_info *info)
{
struct altera_ps_conf *conf = mgr->priv;
- const char dummy[] = {0};
+ static const char dummy[] = {0};
int ret;
if (gpiod_get_value_cansleep(conf->status)) {
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
2018-11-29 23:10 [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size Colin King
@ 2019-01-24 16:49 ` Colin Ian King
2019-01-24 17:16 ` Alan Tull
1 sibling, 0 replies; 4+ messages in thread
From: Colin Ian King @ 2019-01-24 16:49 UTC (permalink / raw)
To: Alan Tull, Moritz Fischer, linux-fpga; +Cc: kernel-janitors, linux-kernel
ping?
On 29/11/2018 23:10, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array dummy on the stack but instead
> make it static. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
>
> After:
> text data bss dec hex filename
> 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 8c18beec6b57..678d0115f840 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> struct fpga_image_info *info)
> {
> struct altera_ps_conf *conf = mgr->priv;
> - const char dummy[] = {0};
> + static const char dummy[] = {0};
> int ret;
>
> if (gpiod_get_value_cansleep(conf->status)) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
2018-11-29 23:10 [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size Colin King
2019-01-24 16:49 ` Colin Ian King
@ 2019-01-24 17:16 ` Alan Tull
2019-01-24 17:22 ` Moritz Fischer
1 sibling, 1 reply; 4+ messages in thread
From: Alan Tull @ 2019-01-24 17:16 UTC (permalink / raw)
To: Colin King; +Cc: Moritz Fischer, linux-fpga, kernel-janitors, linux-kernel
On Thu, Nov 29, 2018 at 5:10 PM Colin King <colin.king@canonical.com> wrote:
Hi Colin,
Thanks!
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array dummy on the stack but instead
> make it static. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
>
> After:
> text data bss dec hex filename
> 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alan Tull <atull@kernel.org>
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 8c18beec6b57..678d0115f840 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> struct fpga_image_info *info)
> {
> struct altera_ps_conf *conf = mgr->priv;
> - const char dummy[] = {0};
> + static const char dummy[] = {0};
> int ret;
>
> if (gpiod_get_value_cansleep(conf->status)) {
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
2019-01-24 17:16 ` Alan Tull
@ 2019-01-24 17:22 ` Moritz Fischer
0 siblings, 0 replies; 4+ messages in thread
From: Moritz Fischer @ 2019-01-24 17:22 UTC (permalink / raw)
To: Alan Tull; +Cc: Colin King, linux-fpga, kernel-janitors, linux-kernel
Hi Colin,
sorry dropped of my radar.
On Thu, Jan 24, 2019 at 9:17 AM Alan Tull <atull@kernel.org> wrote:
>
> On Thu, Nov 29, 2018 at 5:10 PM Colin King <colin.king@canonical.com> wrote:
>
> Hi Colin,
>
> Thanks!
>
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Don't populate the const array dummy on the stack but instead
> > make it static. Makes the object code smaller by 26 bytes:
> >
> > Before:
> > text data bss dec hex filename
> > 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
> >
> > After:
> > text data bss dec hex filename
> > 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
>
>
> > ---
> > drivers/fpga/altera-ps-spi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> > index 8c18beec6b57..678d0115f840 100644
> > --- a/drivers/fpga/altera-ps-spi.c
> > +++ b/drivers/fpga/altera-ps-spi.c
> > @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> > struct fpga_image_info *info)
> > {
> > struct altera_ps_conf *conf = mgr->priv;
> > - const char dummy[] = {0};
> > + static const char dummy[] = {0};
> > int ret;
> >
> > if (gpiod_get_value_cansleep(conf->status)) {
> > --
> > 2.19.1
> >
Moritz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-24 17:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29 23:10 [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size Colin King
2019-01-24 16:49 ` Colin Ian King
2019-01-24 17:16 ` Alan Tull
2019-01-24 17:22 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).