Re: [PATCH v3 21/27] MAINTAINERS: get rid of non-existing Documentation/fpga

Re: [PATCH v3 21/27] MAINTAINERS: get rid of non-existing Documentation/fpga

[Alan Tull]

On Thu, Jun 14, 2018 at 11:09 AM, Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> wrote:
> This directory seems to have moved to a new place
> (Documentation/driver-api/fpga/), with is already at MAINTAINERS.
>
> So, get rid of the old location.

Wow, you caught that fast!  There's other documentation coming to this
directory soon.  IMO we might as well leave it.  We don't need to keep
adding and deleting this line from MAINTAINERS.

Also, why didn't you cc linux-fpga mailing list on this?  I guess you
ran get_maintainer.pl after adding this patch? :)

Alan

>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <mdf@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 783ce44b3e7a..67641f5bb373 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5632,7 +5632,6 @@ L:        linux-fpga@vger.kernel.org
>  S:     Maintained
>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git
>  Q:     http://patchwork.kernel.org/project/linux-fpga/list/
> -F:     Documentation/fpga/
>  F:     Documentation/driver-api/fpga/
>  F:     Documentation/devicetree/bindings/fpga/
>  F:     drivers/fpga/
> --
> 2.17.1
>

Re: [PATCH v3 21/27] MAINTAINERS: get rid of non-existing Documentation/fpga

[Mauro Carvalho Chehab]

Em Thu, 14 Jun 2018 11:39:20 -0500
Alan Tull <atull@kernel.org> escreveu:

> On Thu, Jun 14, 2018 at 11:09 AM, Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org> wrote:
> > This directory seems to have moved to a new place
> > (Documentation/driver-api/fpga/), with is already at MAINTAINERS.
> >
> > So, get rid of the old location.  
> 
> Wow, you caught that fast!

Just a coincidence :-) I had to rebase a pending patch series close to
the end of the merge window.

When I ran the check tool:
	./scripts/documentation-file-ref-check

It detected this.

> There's other documentation coming to this
> directory soon.  IMO we might as well leave it.  We don't need to keep
> adding and deleting this line from MAINTAINERS.

Yeah, sure. I'll drop this hunk for v4.

> 
> Also, why didn't you cc linux-fpga mailing list on this?  I guess you
> ran get_maintainer.pl after adding this patch? :)

Yeah, that was the case. I also had to sanitize the c/c for this
specific patch as get_maintainers.pl isn't good enough to check for
MAINTAINERS access... it usually just get some random noise...

> 
> Alan
> 
> >
> > Cc: Alan Tull <atull@kernel.org>
> > Cc: Moritz Fischer <mdf@kernel.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> >  MAINTAINERS | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 783ce44b3e7a..67641f5bb373 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5632,7 +5632,6 @@ L:        linux-fpga@vger.kernel.org
> >  S:     Maintained
> >  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git
> >  Q:     http://patchwork.kernel.org/project/linux-fpga/list/
> > -F:     Documentation/fpga/
> >  F:     Documentation/driver-api/fpga/
> >  F:     Documentation/devicetree/bindings/fpga/
> >  F:     drivers/fpga/
> > --
> > 2.17.1
> >  



Thanks,
Mauro

Re: [PATCH v3 21/27] MAINTAINERS: get rid of non-existing Documentation/fpga

[Alan Tull]

On Thu, Jun 14, 2018 at 11:52 AM, Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> wrote:
> Em Thu, 14 Jun 2018 11:39:20 -0500
> Alan Tull <atull@kernel.org> escreveu:
>
>> On Thu, Jun 14, 2018 at 11:09 AM, Mauro Carvalho Chehab
>> <mchehab+samsung@kernel.org> wrote:
>> > This directory seems to have moved to a new place
>> > (Documentation/driver-api/fpga/), with is already at MAINTAINERS.
>> >
>> > So, get rid of the old location.
>>
>> Wow, you caught that fast!
>
> Just a coincidence :-) I had to rebase a pending patch series close to
> the end of the merge window.
>
> When I ran the check tool:
>         ./scripts/documentation-file-ref-check
>
> It detected this.

Nice tool.  Thanks for the explanation, it's always good to learn
about another one.

>
>> There's other documentation coming to this
>> directory soon.  IMO we might as well leave it.  We don't need to keep
>> adding and deleting this line from MAINTAINERS.
>
> Yeah, sure. I'll drop this hunk for v4.
>

Thanks!

>>
>> Also, why didn't you cc linux-fpga mailing list on this?  I guess you
>> ran get_maintainer.pl after adding this patch? :)
>
> Yeah, that was the case. I also had to sanitize the c/c for this
> specific patch as get_maintainers.pl isn't good enough to check for
> MAINTAINERS access... it usually just get some random noise...
>
>>
>> Alan
>>
>> >
>> > Cc: Alan Tull <atull@kernel.org>
>> > Cc: Moritz Fischer <mdf@kernel.org>
>> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>> > ---
>> >  MAINTAINERS | 1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 783ce44b3e7a..67641f5bb373 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -5632,7 +5632,6 @@ L:        linux-fpga@vger.kernel.org
>> >  S:     Maintained
>> >  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/atull/linux-fpga.git
>> >  Q:     http://patchwork.kernel.org/project/linux-fpga/list/
>> > -F:     Documentation/fpga/
>> >  F:     Documentation/driver-api/fpga/
>> >  F:     Documentation/devicetree/bindings/fpga/
>> >  F:     drivers/fpga/
>> > --
>> > 2.17.1
>> >
>
>
>
> Thanks,
> Mauro