From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1521208314-4783-1-git-send-email-geert@linux-m68k.org> <1521208314-4783-7-git-send-email-geert@linux-m68k.org> From: Alan Tull Date: Tue, 20 Mar 2018 13:20:11 -0500 Message-ID: Subject: Re: [PATCH v2 06/21] fpga: Remove depends on HAS_DMA in case of platform dependency Content-Type: text/plain; charset="UTF-8" To: Geert Uytterhoeven Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Felipe Balbi , Greg Kroah-Hartman , "James E . J . Bottomley" , "Martin K . Petersen" , Andrew Morton , Mark Brown , Liam Girdwood , Tejun Heo , Herbert Xu , "David S . Miller" , Bartlomiej Zolnierkiewicz , Stefan Richter , Moritz Fischer , Wolfram Sang , Jonathan Cameron , Joerg Roedel , Matias Bjorling , Jassi Brar , Mauro Carvalho Chehab , Ulf Hansson , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Boris Brezillon , Richard Weinberger , Kalle Valo , Ohad Ben-Cohen , Bjorn Andersson , Eric Anholt , Stefan Wahren , iommu@lists.linux-foundation.org, USB list , scsi , ALSA Development Mailing List , linux-ide@vger.kernel.org, Linux Crypto Mailing List , Linux Fbdev development list , linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, Linux I2C , linux-iio@vger.kernel.org, linux-block@vger.kernel.org, Linux Media Mailing List , Linux MMC List , MTD Maling List , netdev , linux-remoteproc@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi , driverdevel , linux-kernel List-ID: On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven wrote: Hi Geert, > Hi Alan, > > On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote: >> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven >> wrote: >> This essentially removes this commit >> >> commit 1c8cb409491403036919dd1c6b45013dc8835a44 >> Author: Sudip Mukherjee >> Date: Wed Aug 3 13:45:46 2016 -0700 >> >> drivers/fpga/Kconfig: fix build failure >> >> While building m32r allmodconfig the build is failing with the error: >> >> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined! >> >> Xilinx Zynq FPGA is using DMA but there was no dependency while >> building. >> >> Link: http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukherjee@gmail.com >> Signed-off-by: Sudip Mukherjee >> Acked-by: Moritz Fischer >> Cc: Alan Tull >> Signed-off-by: Andrew Morton >> Signed-off-by: Linus Torvalds > > Yes it does. The major change is that the first (core) series introduces > all needed dummies to do successful compile-testing on NO_DMA=y platforms. OK yes, I looked at the first patch that does the fix. Looks good. Thanks for doing this. > >>> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >>> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >>> In most cases this other symbol is an architecture or platform specific >>> symbol, or PCI. >>> >>> Generic symbols and drivers without platform dependencies keep their >>> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >>> cannot work anyway. >>> >>> This simplifies the dependencies, and allows to improve compile-testing. >>> >>> Signed-off-by: Geert Uytterhoeven >>> Reviewed-by: Mark Brown >>> Acked-by: Robin Murphy Acked-by: Alan Tull Regards, Alan > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds