From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 In-Reply-To: <20171027140904.Horde.m5O1mdmtNKyY-jthC9ZZmz8@gator4166.hostgator.com> References: <20171026230230.GA4904@embeddedor.com> <20171027140904.Horde.m5O1mdmtNKyY-jthC9ZZmz8@gator4166.hostgator.com> From: Alan Tull Date: Fri, 27 Oct 2017 14:49:55 -0500 Message-ID: Subject: Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get Content-Type: text/plain; charset="UTF-8" To: "Gustavo A. R. Silva" Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel List-ID: On Fri, Oct 27, 2017 at 2:09 PM, Gustavo A. R. Silva wrote: > Hi Alan, > > Quoting Alan Tull : > >> On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva >> wrote: >> >> Hi Gustavo, >> >> Thanks for pointing that out. There's also a similar thing in >> fpga-bridge.c that I need to fix. >> > > Can you share with me what exactly are you trying to fix? > > If the issue is similar I might be able to help. Same fix, but in of_fpga_bridge_get. Checks the output of to_fpga_bridge for NULL. Thanks, Alan > > Thanks > -- > Gustavo A. R. Silva > >> Alan >> >>> Notice that mgr = to_fpga_manager(dev); expands to: >>> >>> mgr = container_of(dev, struct fpga_manager, dev); >>> >>> and container_of is never null, so this null check is >>> unnecessary. >>> >>> Addresses-Coverity-ID: 1397916 >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/fpga/fpga-mgr.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c >>> index 188ffef..33063ca 100644 >>> --- a/drivers/fpga/fpga-mgr.c >>> +++ b/drivers/fpga/fpga-mgr.c >>> @@ -367,8 +367,6 @@ static struct fpga_manager *__fpga_mgr_get(struct >>> device *dev) >>> int ret = -ENODEV; >>> >>> mgr = to_fpga_manager(dev); >>> - if (!mgr) >>> - goto err_dev; >>> >>> /* Get exclusive use of fpga manager */ >>> if (!mutex_trylock(&mgr->ref_mutex)) { >>> -- >>> 2.7.4