From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: Convert to using %pOF instead of full_name
Date: Wed, 19 Jul 2017 09:32:17 -0500 [thread overview]
Message-ID: <CANk1AXSZxj3bb5oXZAyonJ=QgDV3FKuPgSNFDo3m9hzfEtjbbg@mail.gmail.com> (raw)
In-Reply-To: <20170719044221.GA1581@tyrael.ni.corp.natinst.com>
On Tue, Jul 18, 2017 at 11:42 PM, Moritz Fischer <mdf@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
> Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
>> ---
>> drivers/fpga/fpga-region.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
>> index 3b6b2f4182a1..d9ab7c75b14f 100644
>> --- a/drivers/fpga/fpga-region.c
>> +++ b/drivers/fpga/fpga-region.c
>> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>> of_node_put(child_region);
>>
>> if (ret)
>> - pr_err("firmware-name not allowed in child FPGA region: %s",
>> - child_region->full_name);
>> + pr_err("firmware-name not allowed in child FPGA region: %pOF",
>> + child_region);
>>
>> return ret;
>> }
>> --
>> 2.11.0
>>
next prev parent reply other threads:[~2017-07-19 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170718214339.7774-22-robh@kernel.org>
2017-07-19 4:42 ` [PATCH] fpga: Convert to using %pOF instead of full_name Moritz Fischer
2017-07-19 14:32 ` Alan Tull [this message]
2017-08-09 21:54 ` Rob Herring
2017-08-10 14:16 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANk1AXSZxj3bb5oXZAyonJ=QgDV3FKuPgSNFDo3m9hzfEtjbbg@mail.gmail.com' \
--to=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).