From: Alan Tull <atull@kernel.org>
To: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-fpga@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Moritz Fischer <mdf@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: socfpga: fix base address of SDR controller
Date: Tue, 29 Jan 2019 16:30:25 -0600 [thread overview]
Message-ID: <CANk1AXTcbqgoCYkTY-ssMvpAbdoncrkOxyRfu-piLE2tQ15a2g@mail.gmail.com> (raw)
In-Reply-To: <20190129200858.19773-1-goldsimon@gmx.de>
On Tue, Jan 29, 2019 at 2:09 PM Simon Goldschmidt
<simon.k.r.goldschmidt@gmail.com> wrote:
Hi Simon,
Thanks for submitting. A couple of things...
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index f365003f0..8f6c1a5d6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -788,9 +788,9 @@
> reg = <0xfffec000 0x100>;
> };
>
> - sdr: sdr@ffc25000 {
> + sdr: sdr@ffc20000 {
> compatible = "altr,sdr-ctl", "syscon";
> - reg = <0xffc25000 0x1000>;
> + reg = <0xffc20000 0x6000>;
The binding doc will also need this change (in a separate patch)
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt
> diff --git a/arch/arm/mach-socfpga/self-refresh.S b/arch/arm/mach-socfpga/self-refresh.S
> index f2d7f883e..bd7759357 100644
> --- a/arch/arm/mach-socfpga/self-refresh.S
> +++ b/arch/arm/mach-socfpga/self-refresh.S
> @@ -19,8 +19,8 @@
> #define MAX_LOOP_COUNT 1000
>
> /* Register offset */
> -#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x54
> -#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x58
> +#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x5054
> +#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x5058
These offsets are used for ldr/sdr and are limited to 12 bits. This
won't build if CONFIG_SOCFPGA_SUSPEND is enabled.
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:
Assembler messages:
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:65:
Error: bad immediate value for offset (20564)
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:67:
Error: bad immediate value for offset (20564)
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:72:
Error: bad immediate value for offset (20568)
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:101:
Error: bad immediate value for offset (20564)
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:103:
Error: bad immediate value for offset (20564)
/home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:108:
Error: bad immediate value for offset (20568)
/home/atull/repos/linux-socfpga/scripts/Makefile.build:367: recipe for
target 'arch/arm/mach-socfpga/self-refresh.o' failed
Thanks,
Alan
next prev parent reply other threads:[~2019-01-29 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 20:08 [PATCH] ARM: socfpga: fix base address of SDR controller Simon Goldschmidt
2019-01-29 22:30 ` Alan Tull [this message]
2019-01-30 6:08 ` Simon Goldschmidt
2019-01-30 0:16 ` Dinh Nguyen
2019-01-30 6:00 ` Simon Goldschmidt
2019-01-30 15:50 ` Dinh Nguyen
2019-01-30 16:28 ` Simon Goldschmidt
2019-02-01 15:13 ` Dinh Nguyen
2019-02-01 15:50 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXTcbqgoCYkTY-ssMvpAbdoncrkOxyRfu-piLE2tQ15a2g@mail.gmail.com \
--to=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
--cc=simon.k.r.goldschmidt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).