From: Moritz Fischer <mdf@kernel.org>
To: Richard Gong <richard.gong@linux.intel.com>
Cc: Moritz Fischer <mdf@kernel.org>,
gregkh@linuxfoundation.org, trix@redhat.com,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
dinguyen@kernel.org, sridhar.rajagopal@intel.com,
richard.gong@intel.com
Subject: Re: [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
Date: Sat, 21 Nov 2020 17:10:27 -0800 [thread overview]
Message-ID: <X7m6gy/B8DiafyYQ@archbook> (raw)
In-Reply-To: <d8b58b40-63c6-115e-8e61-f092e3f050b3@linux.intel.com>
Richard,
On Wed, Nov 18, 2020 at 12:16:09PM -0600, Richard Gong wrote:
> > > -#define COMMAND_RECONFIG_FLAG_PARTIAL 1
> > > +#define COMMAND_RECONFIG_FLAG_PARTIAL 0
> > > +#define COMMAND_AUTHENTICATE_BITSTREAM 1
> >
> > Can you explain how this commit by itself doesn't break things?
> >
> > Before this change firmware expected BIT(0) to be set for partial
> > reconfiguration, now BIT(0) suddenly means authentication? How doest his
> > work? :)
> > > Was there a firmware version change? Did this never work before?
> >
> > If this is version depenedent for firmware, then this might need a
> > different compatible string / id / some form of probing?
> >
> > Entirely possible that I'm missing something, but it doesn't *seem*
> > right.
>
> It did work before.
>
> Before this change, firmware only checks if the received flag value is zero.
> If the value is zero, it preforms full reconfiguration. Otherwise it does
> partial reconfiguration.
>
> To support bitstream authentication feature, firmware is updated to check
> the received flag value as below:
> 0 --- full reconfiguration
> BIT(0) --- partial reconfiguration
> BIT(1) --- bitstream authentication
So there are two different versions of firmware involved that behave
differently?
Old firmware:
- ctype.flags = 0x0 -> Full reconfig
- ctype.flags != 0 -> Partial reconfig
New firmware:
- ctype.flags = 0x0 -> Full reconfig
- ctype.flags = 0x1 -> Partial reconfig
- ctype.flags = 0x2 -> Authenticate
Old software:
- Send 0x0 for Full
- Send 0x1 for Partial
New software:
- Send 0x0 for Full
- Send 0x1 for Partial
- Send 0x2 for Auth
If I send request for authentication BIT(1) (new software) to old
firmware it'd try and attempt a partial reconfiguration with the data I
send? Is that safe?
Is there a way for software to figure out the firmware version and do
the right thing?
> Therefore I have updated the command flag setting at Intel service layer
> driver to align with firmware.
>
> Regards,
> Richard
>
> > > /**
> > > * Timeout settings for service clients:
> > > --
> > > 2.7.4
> > >
> >
> > Cheers,
> > Moritz
> >
Thanks,
Moritz
next prev parent reply other threads:[~2020-11-22 1:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:29 [PATCHv2 0/5] Extend Intel service layer, FPGA manager and region richard.gong
2020-11-18 14:29 ` [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag richard.gong
2020-11-18 15:30 ` Moritz Fischer
2020-11-18 18:16 ` Richard Gong
2020-11-22 1:10 ` Moritz Fischer [this message]
2020-11-30 18:55 ` Richard Gong
2020-12-01 4:31 ` Moritz Fischer
2020-12-01 19:30 ` Richard Gong
2020-12-01 19:19 ` Moritz Fischer
2020-12-01 20:52 ` Richard Gong
2020-11-18 14:29 ` [PATCHv2 2/5] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2020-11-18 14:29 ` [PATCHv2 3/5] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2020-11-18 14:29 ` [PATCHv2 4/5] dt-bindings: fpga: " richard.gong
2020-11-18 14:29 ` [PATCHv2 5/5] fpga: stratix10-soc: extend driver for bitstream authentication richard.gong
2020-12-14 14:03 ` [PATCHv2 0/5] Extend Intel service layer, FPGA manager and region Richard Gong
2020-12-14 14:05 ` Greg KH
2020-12-14 14:43 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7m6gy/B8DiafyYQ@archbook \
--to=mdf@kernel.org \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=sridhar.rajagopal@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).