From: Moritz Fischer <mdf@kernel.org>
To: David Gow <davidgow@google.com>
Cc: Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
Date: Sat, 21 Nov 2020 16:18:10 -0800 [thread overview]
Message-ID: <X7muQm+0089dbLS9@archbook> (raw)
In-Reply-To: <20201120234648.4050910-1-davidgow@google.com>
On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
>
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
>
> Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>
> Changes since v1:
> ( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ )
> - Add Fixes tag
>
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
> tristate "FPGA Device Feature List (DFL) support"
> select FPGA_BRIDGE
> select FPGA_REGION
> + depends on HAS_IOMEM
> help
> Device Feature List (DFL) defines a feature list structure that
> creates a linked list of feature headers within the MMIO space
> --
> 2.29.2.454.gaff20da3a2-goog
>
Applied to for-5.10,
I fixed up your commit message (dropped the drivers:)
- Moritz
prev parent reply other threads:[~2020-11-22 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 23:46 [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
2020-11-22 0:18 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7muQm+0089dbLS9@archbook \
--to=mdf@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).