From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tom Rix <trix@redhat.com>
Cc: matthew.gerlach@linux.intel.com, hao.wu@intel.com,
yilun.xu@intel.com, russell.h.weight@intel.com,
basheer.ahmed.muddebihal@intel.com, mdf@kernel.org,
linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, tianfei.zhang@intel.com,
corbet@lwn.net, gregkh@linuxfoundation.org,
linux-serial@vger.kernel.org, jirislaby@kernel.org,
geert+renesas@glider.be, niklas.soderlund+renesas@ragnatech.se,
macro@orcam.me.uk, johan@kernel.org, lukas@wunner.de,
ilpo.jarvinen@linux.intel.com, marpagan@redhat.com,
bagasdotme@gmail.com
Subject: Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1
Date: Thu, 29 Dec 2022 22:41:12 +0200 [thread overview]
Message-ID: <Y637aBTrbRloUtvD@smile.fi.intel.com> (raw)
In-Reply-To: <628c125a-5a84-e1bd-7724-2637315cc35e@redhat.com>
On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote:
> On 12/28/22 10:16 AM, matthew.gerlach@linux.intel.com wrote:
...
> > struct dfl_feature_info {
> > u16 fid;
> > u8 revision;
> > + u8 dfh_version;
> > struct resource mmio_res;
> > void __iomem *ioaddr;
> > struct list_head node;
> > unsigned int irq_base;
> > unsigned int nr_irqs;
> > + unsigned int param_size;
> > + u64 params[];
> u64 *params
This will break the overflow.h macros, no?
Besides that it will break the code for sure as it's not an equivalent.
> > };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-29 20:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 18:16 [PATCH v8 0/4] Enhance definition of DFH and use enhancements for UART driver matthew.gerlach
2022-12-28 18:16 ` [PATCH v8 1/4] Documentation: fpga: dfl: Add documentation for DFHv1 matthew.gerlach
2022-12-29 15:31 ` Tom Rix
2022-12-29 18:48 ` matthew.gerlach
2022-12-28 18:16 ` [PATCH v8 2/4] fpga: dfl: Add DFHv1 Register Definitions matthew.gerlach
2022-12-28 18:16 ` [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1 matthew.gerlach
2022-12-29 9:57 ` Andy Shevchenko
2022-12-29 17:31 ` matthew.gerlach
2022-12-29 16:18 ` Tom Rix
2022-12-29 18:25 ` matthew.gerlach
2022-12-29 20:41 ` Andy Shevchenko [this message]
2023-01-02 16:54 ` matthew.gerlach
2023-01-02 17:27 ` Andy Shevchenko
2023-01-02 17:28 ` Andy Shevchenko
2023-01-02 18:09 ` matthew.gerlach
2022-12-30 9:23 ` Xu Yilun
2023-01-02 18:25 ` matthew.gerlach
2022-12-28 18:16 ` [PATCH v8 4/4] tty: serial: 8250: add DFL bus driver for Altera 16550 matthew.gerlach
2022-12-29 9:58 ` Andy Shevchenko
2022-12-29 17:33 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y637aBTrbRloUtvD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=basheer.ahmed.muddebihal@intel.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).