From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40129C54EBC for ; Mon, 2 Jan 2023 17:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbjABR1Q (ORCPT ); Mon, 2 Jan 2023 12:27:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjABR1P (ORCPT ); Mon, 2 Jan 2023 12:27:15 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8534419F; Mon, 2 Jan 2023 09:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672680434; x=1704216434; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UVkcS5la5Y5TVCgYNVEFB3WxJAux74GvxS4u0bUe4Vk=; b=bUMIBTvm2mnWUao5FKWSjMn4e775ZxKHljdZECqzE2ppJ8isq6cMeGbj LRv1oX8Ss2MOGnzUYRiIpzqMKOhzEMbmrKtNUQWZ8zt5/4VF6OIxlLCbq KGQIS8i79S5yy5fbMpX23CCjAzn+jAWGhPHCukIAbtaYLrxs2kSC2oQmr b+FAWZRHNftrxL3vECIAyM5wCVDWj7e8FzUa+b5TYZmCRXstQNDyJXmkT r0xQZry8cgvKuc7YAZ0aLGd6rnkNbo9aP+jHbyIinMxxHPL8cxDZUHjS1 to5LCF1I6iNL/c5PWPyfTV973riJfZBkYhDnTV7gwNMw0aT0bJ9ER2mi2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="320231579" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="320231579" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 09:27:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="656529549" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="656529549" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 02 Jan 2023 09:27:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pCOaY-003WXH-0W; Mon, 02 Jan 2023 19:27:06 +0200 Date: Mon, 2 Jan 2023 19:27:05 +0200 From: Andy Shevchenko To: matthew.gerlach@linux.intel.com Cc: Tom Rix , hao.wu@intel.com, yilun.xu@intel.com, russell.h.weight@intel.com, basheer.ahmed.muddebihal@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, tianfei.zhang@intel.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, geert+renesas@glider.be, niklas.soderlund+renesas@ragnatech.se, macro@orcam.me.uk, johan@kernel.org, lukas@wunner.de, ilpo.jarvinen@linux.intel.com, marpagan@redhat.com, bagasdotme@gmail.com Subject: Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1 Message-ID: References: <20221228181624.1793433-1-matthew.gerlach@linux.intel.com> <20221228181624.1793433-4-matthew.gerlach@linux.intel.com> <628c125a-5a84-e1bd-7724-2637315cc35e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Mon, Jan 02, 2023 at 08:54:48AM -0800, matthew.gerlach@linux.intel.com wrote: > On Thu, 29 Dec 2022, Andy Shevchenko wrote: > > On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote: > > > On 12/28/22 10:16 AM, matthew.gerlach@linux.intel.com wrote: ... > > > > + u64 params[]; > > > u64 *params > > This will break the overflow.h macros, no? > > Besides that it will break the code for sure as it's not an equivalent. > I don't understand how this will break the overflow.h macros. The definition > of struct dfl_feature_info and all of its uses are in a single file, dfl.c. Hint: __must_be_array() As I said, the proposed change is not acceptable since it's not an equivalent. -- With Best Regards, Andy Shevchenko