From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC2BC636CC for ; Tue, 31 Jan 2023 17:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjAaRNW (ORCPT ); Tue, 31 Jan 2023 12:13:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbjAaRNW (ORCPT ); Tue, 31 Jan 2023 12:13:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E615F121 for ; Tue, 31 Jan 2023 09:13:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6717EB81E21 for ; Tue, 31 Jan 2023 17:13:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A049CC433D2; Tue, 31 Jan 2023 17:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675185197; bh=BK2jv+8MItFY9mZ9ZfD+Rlu+wfcG5+pZm4cE2VKQ11s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RnApmwKVIFfEq8W/xeTaJve23GZwtz7dZbbRqHFkZev/mcu57EsSwk6mr2w9LGw4l J5+MHP+vqkKHLg1PB5UJCzqlyiuAwMrpUFM+ir2tpfDirTTTGQYAEghE/eyQTM1U6l 5u80DnuP4CXzFy9YqAXcjaQMoKQzsDWeCtNCddKQ306Cl/tAdpSHPsFNh9ZE+kAmaW aHOLDYjje3Z6uHSM690FlnPwOKm7s16eEDE7c3z230fgszRs0X+d5qlwUu2Gz2N6Hu o09txDWk4Ly7/7yCwaj7YXg6T5t6NDAxHdAmA958cywstkraWxU14EGMe7odrzQ/jv 7wqQZIUaU3LVg== Date: Tue, 31 Jan 2023 17:13:13 +0000 From: Lee Jones To: Xu Yilun Cc: gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org, hao.wu@intel.com, mdf@kernel.org Subject: Re: [PATCH 1/1] fpga: m10bmc-sec: Add support for N6000 Message-ID: References: <20230131024121.940195-1-yilun.xu@intel.com> <20230131024121.940195-2-yilun.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Tue, 31 Jan 2023, Xu Yilun wrote: > On 2023-01-31 at 12:16:44 +0000, Lee Jones wrote: > > On Tue, 31 Jan 2023, Greg KH wrote: > > > > > On Tue, Jan 31, 2023 at 10:58:23AM +0000, Lee Jones wrote: > > > > On Tue, 31 Jan 2023, Xu Yilun wrote: > > > > > > > > > On 2023-01-31 at 09:08:35 +0000, Lee Jones wrote: > > > > > > On Tue, 31 Jan 2023, Xu Yilun wrote: > > > > > > > > > > > > > From: Ilpo Järvinen > > > > > > > > > > > > > > Add support for PMCI-based flash access path and N6000 sec update > > > > > > > support. Access to flash staging area is different for N6000 from that > > > > > > > of the SPI interfaced counterparts. > > > > > > > > > > > > > > Introduce intel_m10bmc_flash_bulk_ops to allow interface specific > > > > > > > differentiations for the flash access path for sec update and make > > > > > > > m10bmc_sec_read/write() in sec update driver to use the new operations. > > > > > > > The .flash_mutex serializes read/read. Flash update (erase+write) must > > > > > > > use ->lock/unlock_write() to prevent reads during update (reads would > > > > > > > timeout on setting flash MUX as BMC will prevent it). > > > > > > > > > > > > > > Create a type specific RSU status reg handler for N6000 because the > > > > > > > field has moved from doorbell to auth result register. > > > > > > > > > > > > > > If a failure is detected while altering the flash MUX, it seems safer > > > > > > > to try to set it back and doesn't seem harmful. Likely there are enough > > > > > > > troubles in that case anyway so setting it back fails too (which is > > > > > > > harmless sans the small extra delay) or just confirms that the value > > > > > > > wasn't changed. > > > > > > > > > > > > > > Co-developed-by: Tianfei zhang > > > > > > > Signed-off-by: Tianfei zhang > > > > > > > Co-developed-by: Russ Weight > > > > > > > Signed-off-by: Russ Weight > > > > > > > Acked-by: Xu Yilun > > > > > > > Signed-off-by: Ilpo Järvinen > > > > > > > Signed-off-by: Lee Jones > > > > > > > Link: https://lore.kernel.org/r/20230116100845.6153-12-ilpo.jarvinen@linux.intel.com > > > > > > > --- > > > > > > > drivers/fpga/intel-m10-bmc-sec-update.c | 51 ++++- > > > > > > > drivers/mfd/intel-m10-bmc-pmci.c | 242 +++++++++++++++++++++++- > > > > > > > include/linux/mfd/intel-m10-bmc.h | 51 +++++ > > > > > > > 3 files changed, 336 insertions(+), 8 deletions(-) > > > > > > > > > > > > I'm confused, what are you trying to achieve? > > > > > > > > > > I'm trying to submit the last patch to Greg's char-misc-next for > > > > > v6.3-rc1. The first 10 patches in this series have been accepted by him > > > > > in this cycle. > > > > > > > > > > This is the only one patch so I just send it rather than making an extra > > > > > pull request. > > > > > > > > That doesn't work with commits being routed in via multiple subsystems > > > > simultaneously. You'll end up with complications due to differing > > > > commit SHAs. > > > > > > > > If you really need this patch to be applied to FPGA (hint: I don't think > > > > it matters), then Greg will need to pull v2 [0] of the immutable topic > > It doesn't matter. > > When I received the pull request v1, I thought Lee want the immutable topic > branch be merged to fpga tree. So I pulled and submitted them to Greg > along with other fpga patches. Sorry for the misunderstanding. Maintainer => maintainer pull-requests are optional. They're super useful if you want to keep developing a particular driver that has been changed elsewhere, since they ensure the avoidance of merge-conflicts at merge time. If you're not attempting to make further changes, there shouldn't be any requirement to pull them. > I'm not sure if this makes trouble for Greg to pull v2 or MFD tree. Honesty, I'd just leave it as it is. It would have been more problematic if a patch which appears earlier in the set was missing, since this may hurt bisectability or render a tree un-buildable. As it stands, it's the last patch, which no other patch in the series should depend on. -- Lee Jones [李琼斯]