From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63602C48BCD for ; Wed, 9 Jun 2021 14:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE3C613BC for ; Wed, 9 Jun 2021 14:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234853AbhFIOzb (ORCPT ); Wed, 9 Jun 2021 10:55:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:60622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhFIOza (ORCPT ); Wed, 9 Jun 2021 10:55:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71A8C611CC; Wed, 9 Jun 2021 14:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623250416; bh=uk70CsMhsrkc3F7Q+zfWu7qyyqHOpmGKxxcZXQstBIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iNvpgC7wex4V8S8lgaahAbFhjyQQstKOynEpf05VLtuC9vJymllfrAUvyTVTi2chv Gy0A3vdXRK9yHXCcmBeQ9Cd8b+/oisxZJ2Q+qOlXWOstIksiBQZz9mv2DDQm16H4sd lPQ0xXxEfjIlh3drZ+zT7b1soLQQrnQG6AVzY/WA= Date: Wed, 9 Jun 2021 16:53:33 +0200 From: Greg KH To: trix@redhat.com Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nava.manne@xilinx.com, dinguyen@kernel.org, krzysztof.kozlowski@canonical.com, yilun.xu@intel.com, arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com, luca@lucaceresoli.net, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs Message-ID: References: <20210609142208.3085451-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609142208.3085451-1-trix@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote: > From: Tom Rix > > The incoming xrt patchset has a toplevel subdir xrt/ > The current fpga/ uses a single dir with filename prefixes to subdivide owners > For consistency, there should be only one way to organize the fpga/ dir. > Because the subdir model scales better, refactor to use it. > The discussion wrt xrt is here: > https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/ > > Follow drivers/net/ethernet/ which has control configs > NET_VENDOR_BLA that map to drivers/net/ethernet/bla > Since fpgas do not have many vendors, drop the 'VENDOR' and use > FPGA_BLA. > > There are several new subdirs > altera/ > dfl/ > lattice/ > xilinx/ > > Each subdir has a Kconfig that has a new/reused > > if FPGA_BLA > ... existing configs ... > endif FPGA_BLA > > Which is sourced into the main fpga/Kconfig > > Each subdir has a Makefile whose transversal is controlled in the > fpga/Makefile by > > obj-$(CONFIG_FPGA_BLA) += bla/ > > Some cleanup to arrange thing alphabetically and make fpga/Makefile's > whitespace look more like net/'s > > Changes from > v1 > Drop renaming files > Cleanup makefiles You can rename the files, you just can not rename the .ko objects without everyone knowing what you are doing and you trying to bury it in the middle of a differently described patch. If you want to do that, do you? I don't really understand why you want to move things around right now other than "we have 40 files in one directory, ick!". greg k-h