* [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
@ 2021-11-30 22:11 Nathan Chancellor
2021-12-01 0:48 ` Xu Yilun
2021-12-03 4:10 ` Moritz Fischer
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-11-30 22:11 UTC (permalink / raw)
To: Moritz Fischer, Wu Hao, Xu Yilun
Cc: Nick Desaulniers, Dan Carpenter, linux-fpga, linux-kernel, llvm,
Nathan Chancellor, Russ Weight, Tom Rix
Clang warns:
drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
return ret;
^~~
ret is only assigned in an error path now so just return 0 directly.
Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
v1 -> v2: https://lore.kernel.org/r/20211129161009.3625548-1-nathan@kernel.org/
* Drop clang's suggestion text (Tom).
* Pick up Russ and Tom's review tags.
drivers/fpga/stratix10-soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 737d14c6e0de..357cea58ec98 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, mgr);
- return ret;
+ return 0;
probe_err:
stratix10_svc_free_channel(priv->chan);
base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
2021-11-30 22:11 [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe() Nathan Chancellor
@ 2021-12-01 0:48 ` Xu Yilun
2021-12-03 4:10 ` Moritz Fischer
1 sibling, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2021-12-01 0:48 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Moritz Fischer, Wu Hao, Nick Desaulniers, Dan Carpenter,
linux-fpga, linux-kernel, llvm, Russ Weight, Tom Rix
On Tue, Nov 30, 2021 at 03:11:24PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
> return ret;
> ^~~
>
> ret is only assigned in an error path now so just return 0 directly.
>
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Thanks,
Yilun
> ---
>
> v1 -> v2: https://lore.kernel.org/r/20211129161009.3625548-1-nathan@kernel.org/
>
> * Drop clang's suggestion text (Tom).
>
> * Pick up Russ and Tom's review tags.
>
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, mgr);
> - return ret;
> + return 0;
>
> probe_err:
> stratix10_svc_free_channel(priv->chan);
>
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
2021-11-30 22:11 [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe() Nathan Chancellor
2021-12-01 0:48 ` Xu Yilun
@ 2021-12-03 4:10 ` Moritz Fischer
1 sibling, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2021-12-03 4:10 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Moritz Fischer, Wu Hao, Xu Yilun, Nick Desaulniers, Dan Carpenter,
linux-fpga, linux-kernel, llvm, Russ Weight, Tom Rix
On Tue, Nov 30, 2021 at 03:11:24PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
> return ret;
> ^~~
>
> ret is only assigned in an error path now so just return 0 directly.
>
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> v1 -> v2: https://lore.kernel.org/r/20211129161009.3625548-1-nathan@kernel.org/
>
> * Drop clang's suggestion text (Tom).
>
> * Pick up Russ and Tom's review tags.
>
> drivers/fpga/stratix10-soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, mgr);
> - return ret;
> + return 0;
>
> probe_err:
> stratix10_svc_free_channel(priv->chan);
>
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
> --
> 2.34.1
>
Applied to for-next,
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-03 4:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 22:11 [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe() Nathan Chancellor
2021-12-01 0:48 ` Xu Yilun
2021-12-03 4:10 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).