From: Lee Jones <lee.jones@linaro.org>
To: Tom Rix <trix@redhat.com>
Cc: Tianfei Zhang <tianfei.zhang@intel.com>,
yilun.xu@intel.com, hao.wu@intel.com,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org,
russell.h.weight@intel.com, matthew.gerlach@linux.intel.com
Subject: Re: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables
Date: Mon, 27 Jun 2022 09:04:00 +0100 [thread overview]
Message-ID: <YrlkcCdYVz8Yri+j@google.com> (raw)
In-Reply-To: <e6e5547e-d4d4-03a5-43cd-90922f9d1959@redhat.com>
On Sat, 25 Jun 2022, Tom Rix wrote:
>
> On 6/24/22 2:22 AM, Tianfei Zhang wrote:
> > It had better use ddata for local variables which
> > directly interacts with dev_get_drvdata()/dev_set_drvdata().
>
> This is a cleanup, not related to the patchset, it should be split from the
> patchset.
So long as they're contained in their own patch, clean-ups are fine.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-06-27 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:22 [PATCH v3 0/3] add PMCI driver support Tianfei Zhang
2022-06-24 9:22 ` [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables Tianfei Zhang
2022-06-25 13:28 ` Tom Rix
2022-06-27 8:04 ` Lee Jones [this message]
2022-06-24 9:22 ` [PATCH v3 2/3] mfd: intel-m10-bmc: add PMCI driver Tianfei Zhang
2022-06-25 13:52 ` Tom Rix
2022-06-27 14:03 ` Zhang, Tianfei
2022-06-27 16:30 ` Xu Yilun
2022-06-28 3:51 ` Zhang, Tianfei
2022-06-24 9:22 ` [PATCH v3 3/3] mfd: intel-m10-bmc: support different BMC base register address Tianfei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrlkcCdYVz8Yri+j@google.com \
--to=lee.jones@linaro.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).