From: Richard Cochran <richardcochran@gmail.com>
To: "Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"Weight, Russell H" <russell.h.weight@intel.com>,
"matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"Khadatare,
RaghavendraX Anand" <raghavendrax.anand.khadatare@intel.com>
Subject: Re: [PATCH v1] ptp: add ToD device driver for Intel FPGA cards
Date: Tue, 14 Mar 2023 13:01:05 -0700 [thread overview]
Message-ID: <ZBDSgVFNVqCWkbxR@hoboy.vegasvil.org> (raw)
In-Reply-To: <BN9PR11MB5483E675D4FA5B37B2A86F76E3BE9@BN9PR11MB5483.namprd11.prod.outlook.com>
On Tue, Mar 14, 2023 at 07:16:28AM +0000, Zhang, Tianfei wrote:
> > Need to handle NULL as well...
>
> It looks like that it doesn't need check NULL for ptp_clock_register(), it handle the NULL case internally and return ERR_PTR(-ENOMEM).
You aren't looking in the right place.
Go back and READ the KernelDoc that I posted and you cut from your reply.
Thanks,
Richard
next prev parent reply other threads:[~2023-03-14 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 3:02 [PATCH v1] ptp: add ToD device driver for Intel FPGA cards Tianfei Zhang
2023-03-13 17:50 ` Marco Pagani
2023-03-15 2:59 ` Zhang, Tianfei
2023-03-16 15:03 ` Zhang, Tianfei
2023-03-13 18:49 ` Richard Cochran
2023-03-14 7:16 ` Zhang, Tianfei
2023-03-14 20:01 ` Richard Cochran [this message]
2023-03-14 10:47 ` Andy Shevchenko
2023-03-14 19:46 ` Richard Cochran
2023-03-15 13:59 ` Andy Shevchenko
2023-03-15 14:37 ` Nicolas Pitre
2023-03-20 13:20 ` Andy Shevchenko
2023-03-20 13:43 ` Nicolas Pitre
2023-03-20 19:41 ` Richard Cochran
2023-03-20 20:53 ` Nicolas Pitre
2023-03-21 13:02 ` Andy Shevchenko
2023-03-21 14:28 ` Zhang, Tianfei
2023-03-21 14:40 ` Andy Shevchenko
2023-03-21 14:52 ` Zhang, Tianfei
2023-03-22 4:17 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBDSgVFNVqCWkbxR@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=raghavendrax.anand.khadatare@intel.com \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).