From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3331CB15F; Thu, 22 Aug 2024 14:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724338027; cv=none; b=epg4UeFsUVzNUPT51NhQct6XiawYj56lso2arK+ravFCZSqmx0vYMWiYsUbd0+mN2QAlzCEWXVLhipucnLy3F/CCSmOXLgh5W/+oZwcLM00/EzpVO4zk4tMZxu5XbLgux3342tLFgCY8leb1LTK2Db/3UAbc0202kzoFw2LnqOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724338027; c=relaxed/simple; bh=4rUGwAtHwvZkZS6ge2m58EPw4N5b7UIy23ZlqKnizKE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uYGp+/CP9U1788cnIhZoWF/pkQdAXrc+dVWl5tKqObs9MWIdDWpBfx+EMFs1lXeDZ8zN8SgF3RtXrgD5HWVfKiY8xBl9Lq3/uONEwF0vuQN2d+hpqLBnoGAQNcQzYyeJYKHFpa4wgcFE8Nu8SfIcNOJHdQsn4nOAkwM0afK244k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: p1H56rRJT7GDagc1KIjLjw== X-CSE-MsgGUID: y8oFQH4vSk2MrxbAQM8vag== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="40221147" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="40221147" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:47:00 -0700 X-CSE-ConnectionGUID: uxpD/yOjR7WoWVFtANZdjQ== X-CSE-MsgGUID: 4I6lRqQgSxeEfW6ZvlId3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="61462125" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:46:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh94p-00000000U65-0MWr; Thu, 22 Aug 2024 17:46:15 +0300 Date: Thu, 22 Aug 2024 17:46:14 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: Jonathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH v3 6/9] ethernet: stmicro: Simplify PCI devres usage Message-ID: References: <20240822134744.44919-1-pstanner@redhat.com> <20240822134744.44919-7-pstanner@redhat.com> Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822134744.44919-7-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Aug 22, 2024 at 03:47:38PM +0200, Philipp Stanner wrote: > stmicro uses PCI devres in the wrong way. Resources requested > through pcim_* functions don't need to be cleaned up manually in the > remove() callback or in the error unwind path of a probe() function. > > Moreover, there is an unnecessary loop which only requests and ioremaps > BAR 0, but iterates over all BARs nevertheless. > > Furthermore, pcim_iomap_regions() and pcim_iomap_table() have been > deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > Replace these functions with pcim_iomap_region(). > > Remove the unnecessary manual pcim_* cleanup calls. > > Remove the unnecessary loop over all BARs. ... > - /* Get the base address of device */ > + /* Request the base address BAR of device */ It's a tautology, "BAR" == Base Address ... -- With Best Regards, Andy Shevchenko