From: Andy Shevchenko <andy@kernel.org>
To: Philipp Stanner <pstanner@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
Xu Yilun <yilun.xu@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Richard Cochran <richardcochran@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Al Viro <viro@zeniv.linux.org.uk>, Li Zetao <lizetao1@huawei.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions()
Date: Fri, 18 Oct 2024 15:36:34 +0300 [thread overview]
Message-ID: <ZxJWUoMg9vYyXwMW@smile.fi.intel.com> (raw)
In-Reply-To: <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com>
On Fri, Oct 18, 2024 at 12:52:15PM +0200, Philipp Stanner wrote:
> On Wed, 2024-10-16 at 13:38 +0300, Andy Shevchenko wrote:
> > On Wed, Oct 16, 2024 at 11:49:05AM +0200, Philipp Stanner wrote:
...
> > > + * This function is DEPRECATED. Do not use it in new code.
> >
> > Interestingly that the syntax of the DEPRECATED is not documented
> > (yet?),
> > however the sphinx parser hints us about **DEPRECATED** format — see
> > Documentation/sphinx/parse-headers.pl:251. In any case the above
> > seems
> > like second used (in a form of the full sentence) and will be updated
> > in accordance with the above mentioned script.
>
> Can't completely follow – so one should always write "**DEPRECATED**",
> correct?
I can't answer to this, because there may be "rendered" form and in this case
it should not be surrounded by double asterisks, otherwise it's better to have
at the start.
> Is that a blocker for you?
Nope, I mentioned this in the last sentence in my previous reply.
> All the docstrings in pci/pci.c and pci/devres.c so far just use
> "DEPRECATED".
Yeah, this, if ever needed, has to be changed at once.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-18 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:49 [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 1/6] PCI: Make pcim_iounmap_region() a public function Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions() Philipp Stanner
2024-10-16 10:38 ` Andy Shevchenko
2024-10-18 10:52 ` Philipp Stanner
2024-10-18 12:36 ` Andy Shevchenko [this message]
2024-10-16 9:49 ` [PATCH v8 3/6] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 4/6] block: mtip32xx: " Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 5/6] gpio: " Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 6/6] ethernet: cavium: " Philipp Stanner
2024-10-28 15:05 ` [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users Philipp Stanner
2024-10-30 21:15 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxJWUoMg9vYyXwMW@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=hao.wu@intel.com \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pstanner@redhat.com \
--cc=richardcochran@gmail.com \
--cc=trix@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).