From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B471FC48BCD for ; Wed, 9 Jun 2021 16:50:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BE9C613D2 for ; Wed, 9 Jun 2021 16:50:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbhFIQwk (ORCPT ); Wed, 9 Jun 2021 12:52:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52270 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbhFIQwj (ORCPT ); Wed, 9 Jun 2021 12:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623257444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=TgeRZ9wLHh00XQce9/PMIw5GPcXz0z9tsBgHdEnBGBJp/CbcaCfivUQyRWGtKm2xOtAmzS FTormIkqIn1ADeYs4FTgeradE3s79we+GZP+UuIVnqPK/esjldvwf2jG0p9qyComIZNlyS 9hAQ2aTRixKD7zEhEDdEgCvVx410nOg= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-c3X2RYP9Pa6P3LCDHnRvXw-1; Wed, 09 Jun 2021 12:50:43 -0400 X-MC-Unique: c3X2RYP9Pa6P3LCDHnRvXw-1 Received: by mail-oo1-f72.google.com with SMTP id 3-20020a4a03030000b029024950bdb69dso10813150ooi.3 for ; Wed, 09 Jun 2021 09:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=HUWEfeuGztjw2F1eNEAHPmR2Y0drVRNFfUe3OZPuOn8oYT96MWdrP8CduJN4BipTk5 yDaj6v1rNs4DvdFmGFW9tsSdegayPC+PmTcAM9+3NWFw35U9YVFM7rCfZ9iLVNo5vzRe L44VoftZ+0fFk3XntdlJHcTa5pCuumCPUGTQnWzKJTwlf8uxkn6gKDiBnLElgyF/3jOx LVJTTh0IB7IaZViqnTeeV8sslLG1CBXua5N/LbEb+V6maW/aFfkqYuD16XCHQ8K2xixa ALJ6tH5Da3QIgBw/UsmyDBPbagP1czDO0XwUBROJzdVTSYfX8A90eR2y+3RQFocZoqsu kEOw== X-Gm-Message-State: AOAM531Q6kL1LJCy9vIebNtkP/WouZDmEDHhERjn6j807I+aD+tAp3ZM F2K6qzad/t9HllTw3zcMCHv6erPxeyWIoBMpDnEoFU382OeOBAJji4yMzmx0eWAO8KXhsyAOg8N 0nSnhyZ6TvU9/z6wYbdqEKw== X-Received: by 2002:a9d:4105:: with SMTP id o5mr316323ote.20.1623257442829; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlqxLGv0YiZs5n6IvS0gh+tJjoLR7xG7pb5AgIFw1+rbYfRnBn+0w4EjGkNDFxCJKICpMBPw== X-Received: by 2002:a9d:4105:: with SMTP id o5mr316304ote.20.1623257442552; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o21sm62806oie.34.2021.06.09.09.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs To: Greg KH Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nava.manne@xilinx.com, dinguyen@kernel.org, krzysztof.kozlowski@canonical.com, yilun.xu@intel.com, arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com, luca@lucaceresoli.net, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210609142208.3085451-1-trix@redhat.com> <2738ee7a-448f-c327-c430-13fb44da45ec@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 09:50:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 6/9/21 9:38 AM, Greg KH wrote: > On Wed, Jun 09, 2021 at 08:08:06AM -0700, Tom Rix wrote: >> On 6/9/21 7:53 AM, Greg KH wrote: >>> On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote: >>>> From: Tom Rix >>>> >>>> The incoming xrt patchset has a toplevel subdir xrt/ >>>> The current fpga/ uses a single dir with filename prefixes to subdivide owners >>>> For consistency, there should be only one way to organize the fpga/ dir. >>>> Because the subdir model scales better, refactor to use it. >>>> The discussion wrt xrt is here: >>>> https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/ >>>> >>>> Follow drivers/net/ethernet/ which has control configs >>>> NET_VENDOR_BLA that map to drivers/net/ethernet/bla >>>> Since fpgas do not have many vendors, drop the 'VENDOR' and use >>>> FPGA_BLA. >>>> >>>> There are several new subdirs >>>> altera/ >>>> dfl/ >>>> lattice/ >>>> xilinx/ >>>> >>>> Each subdir has a Kconfig that has a new/reused >>>> >>>> if FPGA_BLA >>>> ... existing configs ... >>>> endif FPGA_BLA >>>> >>>> Which is sourced into the main fpga/Kconfig >>>> >>>> Each subdir has a Makefile whose transversal is controlled in the >>>> fpga/Makefile by >>>> >>>> obj-$(CONFIG_FPGA_BLA) += bla/ >>>> >>>> Some cleanup to arrange thing alphabetically and make fpga/Makefile's >>>> whitespace look more like net/'s >>>> >>>> Changes from >>>> v1 >>>> Drop renaming files >>>> Cleanup makefiles >>> You can rename the files, you just can not rename the .ko objects >>> without everyone knowing what you are doing and you trying to bury it in >>> the middle of a differently described patch. >>> >>> If you want to do that, do you? I don't really understand why you want >>> to move things around right now other than "we have 40 files in one >>> directory, ick!". >> I am trying to resolve the layout inconsistency between what we have and >> what the xrt patchset does. > Why does it matter? New stuff can be added to a new dir, why worry > about old stuff? What does it hurt? > >> The big issue is the files vs dirs. >> >> Over specified filenames is secondary, so I dropped them. >> >> 40 files in one dir is itself not a problem. >> >> having 40 files and an xrt/ is. > Why is that a "problem"? > >> fpga/ layout should be consistent so the Makefile and Kconfig are easier to >> maintain. > Is it somehow hard to maintain today? Seems pretty trivial to me... This change was to help move xrt along. If you are fine with xrt/, I will drop this patchset. Tom > > thanks, > > greg k-h >